From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jv@jvosburgh.net>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Petr Machata <petrm@nvidia.com>,
Amit Cohen <amcohen@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@gmail.com>,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv2 net-next 2/3] bonding: support aggregator selection based on port priority
Date: Mon, 18 Aug 2025 04:07:06 +0000 [thread overview]
Message-ID: <aKKm6mgrmmFzoVlU@fedora> (raw)
In-Reply-To: <1109153.1755380673@famine>
On Sat, Aug 16, 2025 at 02:44:33PM -0700, Jay Vosburgh wrote:
> >diff --git a/Documentation/networking/bonding.rst b/Documentation/networking/bonding.rst
> >index 874d8a4681ec..151c964562db 100644
> >--- a/Documentation/networking/bonding.rst
> >+++ b/Documentation/networking/bonding.rst
> >@@ -250,7 +250,14 @@ ad_select
> > ports (slaves). Reselection occurs as described under the
> > "bandwidth" setting, above.
> >
> >- The bandwidth and count selection policies permit failover of
> >+ prio or 3
> >+
> >+ The active aggregator is chosen by the highest total sum of
> >+ actor port priorities across its active ports. Note this
> >+ priority is ad_actor_port_prio, not per port prio, which is
> >+ used for primary reselect.
> >+
> >+ The bandwidth, count and prio selection policies permit failover of
>
> Needing to have a caveat here makes me think we should instead
> change the nomenclature. Perhaps "lacp_port_prio"? The standard hasn't
> had "ad" in its name for 20-ish years, so I don't think we should use
> "ad" in user facing options, and common usage these days is to just call
> it "lacp."
>
> Simiarly, I don't think we need "ad" in the option name, either;
> the standard just calls it "actor_port_priority", is there a good reason
Sure, no problem on my side. I will update the option name.
Regards
Hangbin
next prev parent reply other threads:[~2025-08-18 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 10:42 [PATCHv2 net-next 0/3] bonding: support aggregator selection based on port priority Hangbin Liu
2025-08-14 10:42 ` [PATCHv2 net-next 1/3] bonding: add support for per-port LACP actor priority Hangbin Liu
2025-08-14 11:46 ` Jonas Gorski
2025-08-15 6:34 ` Hangbin Liu
2025-08-18 7:58 ` Hangbin Liu
2025-08-14 10:42 ` [PATCHv2 net-next 2/3] bonding: support aggregator selection based on port priority Hangbin Liu
2025-08-16 21:44 ` Jay Vosburgh
2025-08-18 4:07 ` Hangbin Liu [this message]
2025-08-14 10:42 ` [PATCHv2 net-next 3/3] selftests: bonding: add test for LACP actor " Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKKm6mgrmmFzoVlU@fedora \
--to=liuhangbin@gmail.com \
--cc=amcohen@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox