From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: rtnetlink: fix addrlft test flakiness on power-saving systems
Date: Tue, 19 Aug 2025 01:50:51 +0000 [thread overview]
Message-ID: <aKPYe8t7kR_u7DZ7@fedora> (raw)
In-Reply-To: <20250818183012.35f47956@kernel.org>
On Mon, Aug 18, 2025 at 06:30:12PM -0700, Jakub Kicinski wrote:
> On Tue, 15 Jul 2025 04:34:59 +0000 Hangbin Liu wrote:
> > Jakub reported that the rtnetlink test for the preferred lifetime of an
> > address has become quite flaky. The issue started appearing around the 6.16
> > merge window in May, and the test fails with:
> >
> > FAIL: preferred_lft addresses remaining
> >
> > The flakiness might be related to power-saving behavior, as address
> > expiration is handled by a "power-efficient" workqueue.
> >
> > To address this, use slowwait to check more frequently whether the address
> > still exists. This reduces the likelihood of the system entering a low-power
> > state during the test, improving reliability.
>
> It flaked again, after long time of being fine..
>
> https://netdev-3.bots.linux.dev/vmksft-net/results/259361/15-rtnetlink-sh/stdout
Hmm, I think we need to know what's the current preferred_lft and valid_lft
on failed test. Would you please add a debug line so we can get the info
after failed?
slowwait 5 check_addr_not_exist "$devdummy" "10.23.11."
if [ $? -eq 1 ]; then
+ ip addr show dev "$devdummy"
check_err 1
end_test "FAIL: preferred_lft addresses remaining"
return
Thanks
Hangbin
next prev parent reply other threads:[~2025-08-19 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 4:34 [PATCH net] selftests: rtnetlink: fix addrlft test flakiness on power-saving systems Hangbin Liu
2025-07-16 22:10 ` patchwork-bot+netdevbpf
2025-08-19 1:30 ` Jakub Kicinski
2025-08-19 1:50 ` Hangbin Liu [this message]
2025-08-19 2:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKPYe8t7kR_u7DZ7@fedora \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox