From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, "Simon Horman" <horms@kernel.org>,
"Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH net-next v1 0/3] stmmac: stop silently dropping bad checksum packets
Date: Wed, 20 Aug 2025 08:07:00 +0100 [thread overview]
Message-ID: <aKV0FF4FFARJNvZu@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250818090217.2789521-1-o.rempel@pengutronix.de>
On Mon, Aug 18, 2025 at 11:02:14AM +0200, Oleksij Rempel wrote:
> Hi all,
>
> this series reworks how stmmac handles receive checksum offload
> (CoE) errors on dwmac4.
>
> At present, when CoE is enabled, the hardware silently discards any
> frame that fails checksum validation. These packets never reach the
> driver and are not accounted in the generic drop statistics. They are
> only visible in the stmmac-specific counters as "payload error" or
> "header error" packets, which makes it harder to debug or monitor
> network issues.
FYI, there are counters at 0x214 and 0x228 that indicate header
problems, including checksum failures. There are also counters
at 0x234, 0x23c, 0x244 that count udp, tcp and icmp checksum
errors.
So, the hardware does keep statistics. Maybe we should make use
of those rather than the approach in this series?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-08-20 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 9:02 [PATCH net-next v1 0/3] stmmac: stop silently dropping bad checksum packets Oleksij Rempel
2025-08-18 9:02 ` [PATCH net-next v1 1/3] net: stmmac: Correctly handle Rx checksum offload errors Oleksij Rempel
2025-08-18 9:02 ` [PATCH net-next v1 2/3] net: stmmac: dwmac4: report Rx checksum errors in status Oleksij Rempel
2025-08-18 9:02 ` [PATCH net-next v1 3/3] net: stmmac: dwmac4: stop hardware from dropping checksum-error packets Oleksij Rempel
2025-08-20 3:11 ` [PATCH net-next v1 0/3] stmmac: stop silently dropping bad checksum packets patchwork-bot+netdevbpf
2025-08-20 7:07 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKV0FF4FFARJNvZu@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=san@skov.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).