public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jv@jvosburgh.net>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>, Petr Machata <petrm@nvidia.com>,
	Amit Cohen <amcohen@nvidia.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	David Ahern <dsahern@gmail.com>,
	Jonas Gorski <jonas.gorski@gmail.com>,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv4 iproute2-next] iplink: bond_slave: add support for actor_port_prio
Date: Thu, 28 Aug 2025 03:24:55 +0000	[thread overview]
Message-ID: <aK_MB7ikY0hUhGqn@fedora> (raw)
In-Reply-To: <1859262.1756320199@famine>

On Wed, Aug 27, 2025 at 11:43:19AM -0700, Jay Vosburgh wrote:
> Hangbin Liu <liuhangbin@gmail.com> wrote:
> 
> >Add support for the actor_port_prio option for bond slaves.
> >This per-port priority can be used by the bonding driver in ad_select to
> >choose the higher-priority aggregator during failover.
> >
> >Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> >---
> >v4: no update
> >v3: rename ad_actor_port_prio to actor_port_prio
> >v2: no update
> >---
> > ip/iplink_bond.c       |  1 +
> > ip/iplink_bond_slave.c | 18 ++++++++++++++++--
> > man/man8/ip-link.8.in  |  6 ++++++
> > 3 files changed, 23 insertions(+), 2 deletions(-)
> >
> >diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c
> >index d6960f6d9b03..1a2c1b3042a0 100644
> >--- a/ip/iplink_bond.c
> >+++ b/ip/iplink_bond.c
> >@@ -91,6 +91,7 @@ static const char *ad_select_tbl[] = {
> > 	"stable",
> > 	"bandwidth",
> > 	"count",
> >+	"prio",
> 
> 	Should this be actor_port_prio?

hmm, actor_port_prio correspond to the ip link option name, which is also
acceptable.

While in kernel, we defined the select policy as

        { "stable",    BOND_AD_STABLE,    BOND_VALFLAG_DEFAULT},
        { "bandwidth", BOND_AD_BANDWIDTH, 0},
        { "count",     BOND_AD_COUNT,     0},
+       { "prio",      BOND_AD_PRIO,      0},

So I think the prio here should also be OK.

You can decide which one to use.

Thanks
Hangbin

  reply	other threads:[~2025-08-28  3:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25  7:05 [PATCHv4 iproute2-next] iplink: bond_slave: add support for actor_port_prio Hangbin Liu
2025-08-27 18:43 ` Jay Vosburgh
2025-08-28  3:24   ` Hangbin Liu [this message]
2025-08-28 16:59     ` Jay Vosburgh
2025-08-29  1:04       ` Hangbin Liu
2025-08-30  0:22         ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aK_MB7ikY0hUhGqn@fedora \
    --to=liuhangbin@gmail.com \
    --cc=amcohen@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jonas.gorski@gmail.com \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=razor@blackwall.org \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox