From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F83B26E70D for ; Thu, 21 Aug 2025 04:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755750145; cv=none; b=Aww2ejTjHInHr2n9+tJewzOKNbPXNph9kkblest2lwG5cRf8f/8LTbxop6FYg8TAAv274tlMtZnUBNGrI/+jYAJZCLPz+rS6Xmjt+Ye1igepw1CLtEyNicl6jgTQ6YzHMgPmolu8NRmBMwGA52X499xaVpjCKzJd9hVrfYgbVKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755750145; c=relaxed/simple; bh=Tj0fC1N+kfYvRyFVSV+ou/YyPqpHWeVtvl5ebKj1GAQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rGtwohex68Hp5uRtIpbG1EcF49nHb243PxGH49jCB40AtK+e3zqWkAlr0yaxYAa13AuCiM1eFARDCmmgo5Z/mfsYwxVOdz2zFL4I3hhcDrMBMgH5v0jD7X40GCSR2R8K+x+vo3hUqqpMwbAJ1KJ8JJO9hRHjWVOOohLO9JOVS2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uowod-0005My-OQ; Thu, 21 Aug 2025 06:22:19 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uowoc-001M4E-10; Thu, 21 Aug 2025 06:22:18 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uowoc-007uaN-0W; Thu, 21 Aug 2025 06:22:18 +0200 Date: Thu, 21 Aug 2025 06:22:18 +0200 From: Oleksij Rempel To: Kory Maincent Cc: Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH net] net: pse-pd: pd692x0: Skip power budget configuration when undefined Message-ID: References: <20250820133321.841054-1-kory.maincent@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250820133321.841054-1-kory.maincent@bootlin.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On Wed, Aug 20, 2025 at 03:33:21PM +0200, Kory Maincent wrote: > If the power supply's power budget is not defined in the device tree, > the current code still requests power and configures the PSE manager > with a 0W power limit, which is undesirable behavior. > > Skip power budget configuration entirely when the budget is zero, > avoiding unnecessary power requests and preventing invalid 0W limits > from being set on the PSE manager. > > Fixes: 359754013e6a ("net: pse-pd: pd692x0: Add support for PSE PI priority feature") > Signed-off-by: Kory Maincent Acked-by: Oleksij Rempel Thank you! -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |