From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42A38334378 for ; Thu, 21 Aug 2025 13:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755782977; cv=none; b=XeqU/aVCtP+ww7KLWYowpX4H5OpsHsjhJD+9r/t5PHYTjj99j7yoH1wV907NTZ12u7MCYjGErh/UR0QPZGQCxizW2ImzRqufVF7a7gWJAP88jvP9eDxtofvrnMBsbuPFqFd+VYFwvWN1L+L0mC1aG3O245bNc3GJkajr9QEIxqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755782977; c=relaxed/simple; bh=wc5v9uTTIL728+hB7UJTKaDvwgtQwqhmi3Vl/hFU5ak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JZdbFSrBANc4gu8VZrmWt5ByjSR0ZXhj5JDmNNW8qgI2Hh/b9Mvoz3W1B5DPkSxS5Cdjambs6rXxd5LO3IEW8WwZRRENCXJqWGr+ZIDVlxw7VQeG+POsk+ESF5vm8X6O0wssd/RupY3REHQJ6NECcObUwexKVLYf1+h0WZdVTlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WjckZDPu; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WjckZDPu" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-246013de800so135655ad.0 for ; Thu, 21 Aug 2025 06:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755782975; x=1756387775; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J13Esd7nTONrArlNpUKcH+9/JHXUHsKEy/Ib89aPaCQ=; b=WjckZDPuo7y3Xh8jJTXxR+MBh9aWmoKvkLNd0tcrZtigIT2fPZ2vi94ZoJMZl9dgv/ VtoNsQPws+ioJBCOI9Y/Kmqbfd+YXVnue2vpoZH4Fv0XW5JqqdwEnoR0poRFBbLeEKn6 ljtT5o4Q05byKB714hFG2EoUVQEx04JRW+ESAGCTmkqY/DKcloSPi9bFlsy9fSkAPnTK 2ocCKCzcWsRXpBD5wjKi2vyO1VrVMclcC0nPaOw/p16X70FE9z3QlPhl/SjeyEDdaapJ aFhzYxIVeJ/TWNgk4rwWMl06bF+RDyeMS3vOMCUXZzOLkoJD1BMxoQ4fV1jAE4QuTm/N qm1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755782975; x=1756387775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J13Esd7nTONrArlNpUKcH+9/JHXUHsKEy/Ib89aPaCQ=; b=EhbRsJdd3O78C7gWY3RvA1gVYcqnCTAJuiamFYTqNZhQGrGV8yweZvAEmx8TdcPi/t hjWZ6tBcJmU4jbVPGd/+eyAHqcbHb34viKh4d1guQFqTvN/V+yngSuXjRFExFD69Whfq 3IJT4KqS2pJ1QLhm8WLv0m6hs0+Eu8vyzC7UJgdj6bDNnkD++y4KF9QhCfhWH8mhxILM waQkyy7UHEzlRx0RbFk25GU7IyQw6FWsVav1I2L5m1FvZyx7nuJHJhbG7LAy7LYO2TZm CSFymB8k0eKHvM/hSAUWQBVcftgbfetXPcewG8p7KvNHF9U7DKONtRWQ5Foa0dx/RMFS SvXg== X-Forwarded-Encrypted: i=1; AJvYcCXu8UVWaYP7jFQ5GqRuKGNOzxN0iJefb1XIQryXV2XInXZ73M74Nq9v4+BkPANa15aVlUotQQQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/kmqs/LxPIRW9nMs1ZMgx1c/dRz+iqQpwz7IBFI3NDopcUfGF rWBsrPxHWNjsIHMtKZONeRFqub+uZNa1HJDxgsNEAfOYjhM8tri3ofGw24wDf6OCyQ== X-Gm-Gg: ASbGncsuLGb95eQU4AqXwzG0difMR8zvvnPGagchTPURSiiwSu131w11Hq24SbCUC2i boxp7V4QG00759chjCjdZhrA93kBIEB9Ljqc0DZA920+s/OfmgnajZEuEexMxsg8QeMgO1McjAX UVMHN2JFbvUtEi6BTwwxmE42Rj44oKIMLfEh8IuosCda4H1vRqtcMJtp4OK5S2eieBHeP0EBc7/ XplUsX2rMRi3EUQsuPdAWYmJls7pHb+e/GBgchzvWON5mlBr5prxLwq3tuhB4Au4fXpchqdFplr 7sxNwn69gZ6o6skxekNqF+AjgCQVBsj6Ua6OmUs6ZE9e4RyG01sGYBSAlI/Bf3FSvVPNbeUrKlA uGhocvShs+x0ltK/nkgDlf6sKugzsTki5iKKOLTAkeVxKwTEkcb3/K2NnEwxHSA== X-Google-Smtp-Source: AGHT+IEJ89+AicE1lZQ3XnhpL5tHd/m1IsnyOgUW94AR1BOA58fjSEzDksF9jqNKQwq8P3RC6Erj0g== X-Received: by 2002:a17:903:166e:b0:234:b441:4d4c with SMTP id d9443c01a7336-24602317afcmr3273645ad.5.1755782975217; Thu, 21 Aug 2025 06:29:35 -0700 (PDT) Received: from google.com (3.32.125.34.bc.googleusercontent.com. [34.125.32.3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76e7d4fd2f5sm8344077b3a.74.2025.08.21.06.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 06:29:34 -0700 (PDT) Date: Thu, 21 Aug 2025 13:29:29 +0000 From: Carlos Llamas To: Thorsten Leemhuis Cc: Greg Kroah-Hartman , Li Li , Tiffany Yang , John Stultz , Shai Barack , =?iso-8859-1?Q?Thi=E9baud?= Weksteen , kernel-team@android.com, linux-kernel@vger.kernel.org, "David S. Miller" , Joel Fernandes , Todd Kjos , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Donald Hunter , Christian Brauner , Eric Dumazet , "open list:NETWORKING [GENERAL]" , Martijn Coenen , Stephen Rothwell , Linux Next Mailing List , Jakub Kicinski , Linux kernel regressions list , Alice Ryhl , Suren Baghdasaryan , Paolo Abeni , Simon Horman Subject: Re: [PATCH v20 3/5] binder: introduce transaction reports via netlink Message-ID: References: <20250727182932.2499194-1-cmllamas@google.com> <20250727182932.2499194-4-cmllamas@google.com> <2025082145-crabmeat-ounce-e71f@gregkh> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 21, 2025 at 03:00:50PM +0200, Thorsten Leemhuis wrote: > On 21.08.25 14:19, Greg Kroah-Hartman wrote: > > On Thu, Aug 21, 2025 at 10:49:09AM +0200, Thorsten Leemhuis wrote: > >> On 27.07.25 20:29, Carlos Llamas wrote: > >>> From: Li Li > >>> > >>> Introduce a generic netlink multicast event to report binder transaction > >>> failures to userspace. This allows subscribers to monitor these events > >>> and take appropriate actions, such as stopping a misbehaving application > >>> that is spamming a service with huge amount of transactions. > >>> > >>> The multicast event contains full details of the failed transactions, > >>> including the sender/target PIDs, payload size and specific error code. > >>> This interface is defined using a YAML spec, from which the UAPI and > >>> kernel headers and source are auto-generated. > >> > >> It seems to me like this patch (which showed up in -next today after > >> Greg merged it) caused a build error for me in my daily -next builds > >> for Fedora when building tools/net/ynl: > >> > >> """ > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > >> gcc -std=gnu11 -O2 -W -Wall -Wextra -Wno-unused-parameter -Wshadow -c -MMD -c -o ynl.o ynl.c > >> AR ynl.a > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > >> GEN binder-user.c > >> Traceback (most recent call last): > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3673, in > >> main() > >> ~~~~^^ > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3382, in main > >> parsed = Family(args.spec, exclude_ops) > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 1205, in __init__ > >> super().__init__(file_name, exclude_ops=exclude_ops) > >> ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/pyynl/lib/nlspec.py", line 462, in __init__ > >> jsonschema.validate(self.yaml, schema) > >> ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ > >> File "/usr/lib/python3.13/site-packages/jsonschema/validators.py", line 1307, in validate > >> raise error > >> jsonschema.exceptions.ValidationError: 'from_pid' does not match '^[0-9a-z-]+$' > >> > >> Failed validating 'pattern' in schema['properties']['attribute-sets']['items']['properties']['attributes']['items']['properties']['name']: > >> {'pattern': '^[0-9a-z-]+$', 'type': 'string'} > >> > >> On instance['attribute-sets'][0]['attributes'][2]['name']: > >> 'from_pid' > >> make[1]: *** [Makefile:48: binder-user.c] Error 1 > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > >> make: *** [Makefile:25: generated] Error 2 > >> """ > > > > Odd, this works for me. > > Hmmm, happened on various Fedora releases and archs in Fedora's coprs > buildsys for me today. And with a local Fedora 41 x86_64 install, too; > in the latter case (just verified) both when checking out next-20250821 > and 63740349eba78f ("binder: introduce transaction reports via netlink") > from -next. > > > How exactly are you building this? > > Just "cd tools/net/ynl; make". > > Ciao, Thorsten Judging by the regex in the error log it seems there is a new restriction to not using underscores in the yml files. This restriction probably raced with my patch in next. It should be very easy to fix. Can you please try replacing the underscores? $ sed -i 's/_/-/' Documentation/netlink/specs/binder.yaml I think that should fix your build. I'll try to reproduce. -- Carlos Llamas