From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1B32DF715 for ; Thu, 21 Aug 2025 13:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755783544; cv=none; b=GdbMinUrqY0CFt7DwRFiAFc6d8hP5U1Uzj43DVJi4HAq5YGtA2dk4bk64bXJbUXSq81mzPN9YrxR2l9fWPcs34/xR1dbAB5aRAenVQgvjWCJDxUcP14DTM6S74f3Ri8ndjkUVPY2lqsxd2XifPI678vnnriLEgACAf2QUIqf3bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755783544; c=relaxed/simple; bh=UBaomgbe5Pto6k9s8jcQN8o0bdH3iMYe1oFhKjAp01M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=br/2vDaI4JMQT0fs+u6GUQXrtE3Vl1wzt65bEyjZZ6x7km/B05IiM10vDr0KLt6D/w8kx8fJCmg2MIR/n9Czxyc7+ZHAqUq69HUaAKPYNtW9EyVsbqm+t5pMNziRJEl7tBWf4bg2bUmZhDKT1UjZAiu9nRgCOp7cdP6gLOBg+cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=n5pFRIfr; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n5pFRIfr" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-24611734e50so85025ad.1 for ; Thu, 21 Aug 2025 06:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755783541; x=1756388341; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7N9rAjjjlmmVnsb6lYyZUzYXQ/m0Q5K6qvsrUkhsgXc=; b=n5pFRIfrtJN7JZMXIcg9FomDpqXm35VXUOT0hHV/Me6jKlY0VGZ6heo6dKmBQtWU7d 9bw5evGgGCIQmKNMxyqbBxGDt87FjTTovsleJabaYL0nDPksutu1SF8GB/F4RtzIkHry GtjiW4h88UiidARPei+Tz2CwcX4eA6iIh+hJcZNorbPgyZt/R5rXN5dMbs8m+RF+vWpc S/IVfFbU5QkJ0co8umVuGSWm1i2/p9/FmPX0rhniYXWJ16s/qPu5v+0xYZdxML6sF503 l/GDYJ81+nZHoZqFThJxolc3FLAZDlJsshBfAm+vO5jc42Hg3ofoS6L8+rlsx5C9pQH1 XLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755783541; x=1756388341; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7N9rAjjjlmmVnsb6lYyZUzYXQ/m0Q5K6qvsrUkhsgXc=; b=XqtYdVn0EnZWby4cMF6rh0xvZRB8AnbzOpg0c2wgZmJW1Ekf/J2A4XWxgZr+gwKBTw dYhJApSG8S0/ChBxRhZ4lygjZHr7SHgYAPmx8NKlB17CJeh2y/GuNRbakyWrGR83UKF1 U5/kk/ZYYAxRRYa77aeopUsjduxVtMYUOwqJ2j7T+BZjtqCGN8eWzokvpGkiDUCEhHOK 0b/qgsFRnmwrYg0Th/aMWuvOqnOBQvby64sEefMdxrBH2BfotjUSXgGYkwn38SVfUOd7 NQAa99laPoAmIHU464wAAyCi9WMxxsUepx6ak3j2W0rLb+lN7mLx6PCdxR3VcPSDhkkb qLag== X-Forwarded-Encrypted: i=1; AJvYcCUr1qLd8hoVDGimQu/M7cVokTRiBWobHJZzMl/vsKZQCf38RqO1SD+3JsbZNp5KE/GdBiaS3S8=@vger.kernel.org X-Gm-Message-State: AOJu0YwFcKCb5XkkLweoh6CRWG9QT3I1HPOQxPlAjaVldbLN6iMaMgh4 35HuiX/ZppLE+4xQCtEjT/2I3W+1CWoXQGx3jtQpMexpBacLADsmmE3ELVatbO6luA== X-Gm-Gg: ASbGncv8m60gJ+qXh1vjaMDa6eDOkBxOGf3vcDsGi9qM9j4md1BJxtJywffQOthG7Av 2D0kOnF8eBuhfgXOZXNbPEp5KrDc9EWSsRA5rDD/MV1MhrazgulLn4uwRGwGFD1gTH6aM9PUMz5 FTniUkz4qasJ0h1dSlLwIBudvaHsOYd9sZUPWqlf6rU8lHWof3zE9EY9II6N5cqh5pEuKiluqg9 I/SI4TJMoeFQ+bcvpwl+S3/rqNdKbFL13iY517YjcQ5ozQQko+2GdRJet3HInuy9zNz19NF8hjK 8vzpSk0TNXPAGp4NWY5PoPOPcBD2e6u0aymCS2jzylq9UagYkctcmQSE16GKEmqJrXqC5qSW7aG 2TOVQHZpM+o5kCki/b3TixsGtx4z+AZWZP7UykyzBw9atvyKrCnCtfMurfhkCiQ== X-Google-Smtp-Source: AGHT+IEC07DRM954ZauhrF271W70UI0dmUDeDFMbKiMegLnkkgTzAWcZdd3XdKKaCxDubRNrmCtS1g== X-Received: by 2002:a17:903:22d2:b0:240:a4b5:fe0d with SMTP id d9443c01a7336-245ffa5b6cbmr3398745ad.6.1755783540818; Thu, 21 Aug 2025 06:39:00 -0700 (PDT) Received: from google.com (3.32.125.34.bc.googleusercontent.com. [34.125.32.3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4763fb85e7sm4806942a12.12.2025.08.21.06.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 06:38:59 -0700 (PDT) Date: Thu, 21 Aug 2025 13:38:54 +0000 From: Carlos Llamas To: Greg Kroah-Hartman Cc: Thorsten Leemhuis , Li Li , Tiffany Yang , John Stultz , Shai Barack , =?iso-8859-1?Q?Thi=E9baud?= Weksteen , kernel-team@android.com, linux-kernel@vger.kernel.org, "David S. Miller" , Joel Fernandes , Todd Kjos , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Donald Hunter , Christian Brauner , Eric Dumazet , "open list:NETWORKING [GENERAL]" , Martijn Coenen , Stephen Rothwell , Linux Next Mailing List , Jakub Kicinski , Linux kernel regressions list , Alice Ryhl , Suren Baghdasaryan , Paolo Abeni , Simon Horman Subject: Re: [PATCH v20 3/5] binder: introduce transaction reports via netlink Message-ID: References: <20250727182932.2499194-1-cmllamas@google.com> <20250727182932.2499194-4-cmllamas@google.com> <2025082145-crabmeat-ounce-e71f@gregkh> <2025082120-phoney-husband-d028@gregkh> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2025082120-phoney-husband-d028@gregkh> On Thu, Aug 21, 2025 at 03:25:59PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 21, 2025 at 03:00:50PM +0200, Thorsten Leemhuis wrote: > > On 21.08.25 14:19, Greg Kroah-Hartman wrote: > > > On Thu, Aug 21, 2025 at 10:49:09AM +0200, Thorsten Leemhuis wrote: > > >> On 27.07.25 20:29, Carlos Llamas wrote: > > >>> From: Li Li > > >>> > > >>> Introduce a generic netlink multicast event to report binder transaction > > >>> failures to userspace. This allows subscribers to monitor these events > > >>> and take appropriate actions, such as stopping a misbehaving application > > >>> that is spamming a service with huge amount of transactions. > > >>> > > >>> The multicast event contains full details of the failed transactions, > > >>> including the sender/target PIDs, payload size and specific error code. > > >>> This interface is defined using a YAML spec, from which the UAPI and > > >>> kernel headers and source are auto-generated. > > >> > > >> It seems to me like this patch (which showed up in -next today after > > >> Greg merged it) caused a build error for me in my daily -next builds > > >> for Fedora when building tools/net/ynl: > > >> > > >> """ > > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > > >> gcc -std=gnu11 -O2 -W -Wall -Wextra -Wno-unused-parameter -Wshadow -c -MMD -c -o ynl.o ynl.c > > >> AR ynl.a > > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/lib' > > >> make[1]: Entering directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > > >> GEN binder-user.c > > >> Traceback (most recent call last): > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3673, in > > >> main() > > >> ~~~~^^ > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 3382, in main > > >> parsed = Family(args.spec, exclude_ops) > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated/../pyynl/ynl_gen_c.py", line 1205, in __init__ > > >> super().__init__(file_name, exclude_ops=exclude_ops) > > >> ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > >> File "/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/pyynl/lib/nlspec.py", line 462, in __init__ > > >> jsonschema.validate(self.yaml, schema) > > >> ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ > > >> File "/usr/lib/python3.13/site-packages/jsonschema/validators.py", line 1307, in validate > > >> raise error > > >> jsonschema.exceptions.ValidationError: 'from_pid' does not match '^[0-9a-z-]+$' > > >> > > >> Failed validating 'pattern' in schema['properties']['attribute-sets']['items']['properties']['attributes']['items']['properties']['name']: > > >> {'pattern': '^[0-9a-z-]+$', 'type': 'string'} > > >> > > >> On instance['attribute-sets'][0]['attributes'][2]['name']: > > >> 'from_pid' > > >> make[1]: *** [Makefile:48: binder-user.c] Error 1 > > >> make[1]: Leaving directory '/home/kbuilder/ark-vanilla/linux-knurd42/tools/net/ynl/generated' > > >> make: *** [Makefile:25: generated] Error 2 > > >> """ > > > > > > Odd, this works for me. > > > > Hmmm, happened on various Fedora releases and archs in Fedora's coprs > > buildsys for me today. And with a local Fedora 41 x86_64 install, too; > > in the latter case (just verified) both when checking out next-20250821 > > and 63740349eba78f ("binder: introduce transaction reports via netlink") > > from -next. > > > > > How exactly are you building this? > > > > Just "cd tools/net/ynl; make". > > Odd, this works for me in the driver-core-next branch, but in linux-next > it blows up like this. Is it a merge issue somewhere? I don't know > what this tool is doing to attempt to debug it myself, sorry. > > greg k-h The commit enforcing the restriction on underscores is: af852f1f1c95 ("netlink: specs: enforce strict naming of properties") I'm able to reproduce the issue locally now, and switching to dashes fixes it. Sorry, I was not aware of this restriction but I'll send a quick patch to fix this. -- Carlos Llamas