netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: phylink: remove stale an_enabled from doc
@ 2025-08-24  1:30 David Yang
  2025-08-24  8:43 ` Russell King (Oracle)
  2025-08-26  1:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: David Yang @ 2025-08-24  1:30 UTC (permalink / raw)
  To: netdev; +Cc: David Yang, Russell King, linux-kernel

state->an_enabled was removed before, but is left in mac_config() doc,
so clean it.

Fixes: 4ee9b0dcf09f ("net: phylink: remove an_enabled")
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
 include/linux/phylink.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/include/linux/phylink.h b/include/linux/phylink.h
index 30659b615fca..9af0411761d7 100644
--- a/include/linux/phylink.h
+++ b/include/linux/phylink.h
@@ -320,9 +320,8 @@ int mac_prepare(struct phylink_config *config, unsigned int mode,
  *   If in 802.3z mode, the link speed is fixed, dependent on the
  *   @state->interface. Duplex and pause modes are negotiated via
  *   the in-band configuration word. Advertised pause modes are set
- *   according to the @state->an_enabled and @state->advertising
- *   flags. Beware of MACs which only support full duplex at gigabit
- *   and higher speeds.
+ *   according to @state->advertising. Beware of MACs which only
+ *   support full duplex at gigabit and higher speeds.
  *
  *   If in Cisco SGMII mode, the link speed and duplex mode are passed
  *   in the serial bitstream 16-bit configuration word, and the MAC
@@ -331,7 +330,7 @@ int mac_prepare(struct phylink_config *config, unsigned int mode,
  *   responsible for reading the configuration word and configuring
  *   itself accordingly.
  *
- *   Valid state members: interface, an_enabled, pause, advertising.
+ *   Valid state members: interface, pause, advertising.
  *
  * Implementations are expected to update the MAC to reflect the
  * requested settings - i.o.w., if nothing has changed between two
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phylink: remove stale an_enabled from doc
  2025-08-24  1:30 [PATCH net-next] net: phylink: remove stale an_enabled from doc David Yang
@ 2025-08-24  8:43 ` Russell King (Oracle)
  2025-08-26  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2025-08-24  8:43 UTC (permalink / raw)
  To: David Yang; +Cc: netdev, linux-kernel

On Sun, Aug 24, 2025 at 09:30:03AM +0800, David Yang wrote:
> state->an_enabled was removed before, but is left in mac_config() doc,
> so clean it.
> 
> Fixes: 4ee9b0dcf09f ("net: phylink: remove an_enabled")
> Signed-off-by: David Yang <mmyangfl@gmail.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phylink: remove stale an_enabled from doc
  2025-08-24  1:30 [PATCH net-next] net: phylink: remove stale an_enabled from doc David Yang
  2025-08-24  8:43 ` Russell King (Oracle)
@ 2025-08-26  1:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-08-26  1:10 UTC (permalink / raw)
  To: Yangfl; +Cc: netdev, linux, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 24 Aug 2025 09:30:03 +0800 you wrote:
> state->an_enabled was removed before, but is left in mac_config() doc,
> so clean it.
> 
> Fixes: 4ee9b0dcf09f ("net: phylink: remove an_enabled")
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
>  include/linux/phylink.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Here is the summary with links:
  - [net-next] net: phylink: remove stale an_enabled from doc
    https://git.kernel.org/netdev/net-next/c/df534e757321

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-08-26  1:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-24  1:30 [PATCH net-next] net: phylink: remove stale an_enabled from doc David Yang
2025-08-24  8:43 ` Russell King (Oracle)
2025-08-26  1:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).