netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Ilya K <me@0upti.me>
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
	hkallweit1@gmail.com, kuba@kernel.org, matt@traverse.com.au,
	netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net 3/3] net: phylink: disable autoneg for interfaces that have no inband
Date: Mon, 8 Sep 2025 08:44:08 +0100	[thread overview]
Message-ID: <aL6JSEhTRh2q_Jxe@shell.armlinux.org.uk> (raw)
In-Reply-To: <7e463b05-ae28-4a98-b8fa-bdff266aa62f@0upti.me>

On Mon, Sep 08, 2025 at 10:38:59AM +0300, Ilya K wrote:
> Hey folks, this seems to have regressed a different setup: I have a Banana Pi BPi-R4 connected to a dumb unmanaged switch with a 10GbaseCR cable, and it fails to negotiate a link with a21202743f9c applied. Reverting it makes things work again. It seems like phylink_get_inband_type doesn't handle base-R modes at all? I'll maybe have some more time to poke this myself later this week, but throwing it out there in case anyone more experienced has ideas.

10GBASE-CR (based upon BASE-R) has no inband signalling for
autonegotiation.

Please enable debugging in phylink and include this is any bug report.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-09-08  7:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-31 17:34 [PATCH net 0/3] net: fix optical SFP failures Russell King (Oracle)
2025-08-31 17:34 ` [PATCH net 1/3] net: phy: add phy_interface_weight() Russell King (Oracle)
2025-09-02 21:51   ` Andrew Lunn
2025-08-31 17:34 ` [PATCH net 2/3] net: phylink: provide phylink_get_inband_type() Russell King (Oracle)
2025-09-02 21:52   ` Andrew Lunn
2025-08-31 17:34 ` [PATCH net 3/3] net: phylink: disable autoneg for interfaces that have no inband Russell King (Oracle)
2025-09-02 22:51   ` Vladimir Oltean
2025-09-08  7:38   ` Ilya K
2025-09-08  7:44     ` Russell King (Oracle) [this message]
2025-09-08 17:07       ` Ilya K
2025-09-02 23:30 ` [PATCH net 0/3] net: fix optical SFP failures patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aL6JSEhTRh2q_Jxe@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=matt@traverse.com.au \
    --cc=me@0upti.me \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).