From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246B92DAFBD; Fri, 29 Aug 2025 22:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756507393; cv=none; b=q9MRyDAjsSq7NdYOKL/aFfub8/fFu0Ns/Qc5t3R4+p58supWzHIiH2jBrWLWx/dhrTpq0n74ssjek2pIuM5w2iFRbWqNJ+v/T5ZZ7pojOKTGb1i3SNdsucEeRRD3JjH+BOecOMFoEQuE7KQ2QQBywp3r/J75fV8u58/5luSAcBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756507393; c=relaxed/simple; bh=ndLcDPeWdN0wA/DqMpvNhcnp+pz1BGrAusiuh4ipoZM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nQSKIsSJPeH7+oELkltYz5zGN7M0+etPAFFoKMZrktVKyMh56FeVE0u0mLlh5HG0tHJAvhGgetROouVW+My3Ge0lB+lcKzYFhLohxEQK18V/xZWMNyRZRoVAUQ9KbXFf3en1TLwhGNc057FKr/WtfGmYHfV38FBHTOpv+YQlrzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LnocQWii; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LnocQWii" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D1F0C4CEF0; Fri, 29 Aug 2025 22:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756507392; bh=ndLcDPeWdN0wA/DqMpvNhcnp+pz1BGrAusiuh4ipoZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LnocQWiiwbqNCSnULb0Q8VaKKsRkgCBvomsAiupePPOlZ0m4VDs5AX4u/M3C9mP+q p0NwzqV10rYMOw2wnnFKztItsSfVIrI5Ngsr31s8UjvO0bMkXWYRKz//dpdH+VOqej s1Pw92nQwOZ8H+v2YLUzXxTyNqrwxdBUNOejpflfqjcph/OxPL+abaWehP/yXfeMGO /bzZsxjCh2lX36xQM1GofOpISlIAoW6vgyOGBDnzxxOk0Wmv1sY5XHc22m0wrxu3+n qGuoK9CoV52thU7J+qbO2bzAB4uzi5/KhxKWNu3wbn6kouPp/g6zVrMIfbNRYL6dj4 uXoJg8FTIsdOA== Date: Fri, 29 Aug 2025 15:43:11 -0700 From: Saeed Mahameed To: cpaasch@openai.com Cc: Gal Pressman , Dragos Tatulea , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v4 0/2] net/mlx5: Avoid payload in skb's linear part for better GRO-processing Message-ID: References: <20250828-cpaasch-pf-927-netmlx5-avoid-copying-the-payload-to-the-malloced-area-v4-0-bfcd5033a77c@openai.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20250828-cpaasch-pf-927-netmlx5-avoid-copying-the-payload-to-the-malloced-area-v4-0-bfcd5033a77c@openai.com> On 28 Aug 20:36, Christoph Paasch via B4 Relay wrote: >When LRO is enabled on the MLX, mlx5e_skb_from_cqe_mpwrq_nonlinear >copies parts of the payload to the linear part of the skb. > >This triggers suboptimal processing in GRO, causing slow throughput,... > >This patch series addresses this by using eth_get_headlen to compute the >size of the protocol headers and only copy those bits. This results in >a significant throughput improvement (detailled results in the specific >patch). > >Signed-off-by: Christoph Paasch LGTM, I would love to take this to net-next-mlx5 and submit it back to netdev after regression testing if that's ok? Christoph? Anyway I will wait for Jakub to mark this as "awaiting-upstream" or if he applies it directly then fine.