From: Brett Sheffield <bacs@librecast.net>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Oscar Maes <oscmaes92@gmail.com>,
netdev@vger.kernel.org, bacs@librecast.net, kuba@kernel.org,
davem@davemloft.net, dsahern@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v4] selftests: net: add test for destination in broadcast packets
Date: Tue, 2 Sep 2025 11:33:22 +0200 [thread overview]
Message-ID: <aLa54kZLIV3zbi2v@karahi.gladserv.com> (raw)
In-Reply-To: <03991134-4007-422b-b25a-003a85c1edb0@redhat.com>
On 2025-09-02 10:49, Paolo Abeni wrote:
> On 8/28/25 1:42 PM, Oscar Maes wrote:
> > Add test to check the broadcast ethernet destination field is set
> > correctly.
> >
> > This test sends a broadcast ping, captures it using tcpdump and
> > ensures that all bits of the 6 octet ethernet destination address
> > are correctly set by examining the output capture file.
> >
> > Signed-off-by: Oscar Maes <oscmaes92@gmail.com>
> > Co-authored-by: Brett A C Sheffield <bacs@librecast.net>
>
> I'm sorry for nit-picking, but the sob/tag-chain is wrong, please have a
> look at:
>
> https://elixir.bootlin.com/linux/v6.16.4/source/Documentation/process/submitting-patches.rst#L516
Thanks Paolo. So, something like:
Co-developed-by: Brett A C Sheffield <bacs@librecast.net>
Signed-off-by: Brett A C Sheffield <bacs@librecast.net>
Co-developed-by: Oscar Maes <oscmaes92@gmail.com>
Signed-off-by: Oscar Maes <oscmaes92@gmail.com>
with the last sign-off by Oscar because he is submitting?
Brett
next prev parent reply other threads:[~2025-09-02 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 11:42 [PATCH net v4] selftests: net: add test for destination in broadcast packets Oscar Maes
2025-08-28 12:16 ` Brett A C Sheffield
2025-08-29 11:19 ` Simon Horman
2025-08-29 11:44 ` Brett Sheffield
2025-08-29 13:11 ` Brett Sheffield
2025-09-01 12:25 ` Oscar Maes
2025-09-02 8:49 ` Paolo Abeni
2025-09-02 9:33 ` Brett Sheffield [this message]
2025-09-02 9:57 ` Paolo Abeni
2025-09-02 10:25 ` Brett Sheffield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLa54kZLIV3zbi2v@karahi.gladserv.com \
--to=bacs@librecast.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oscmaes92@gmail.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).