From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bregans-0.gladserv.net (bregans-0.gladserv.net [185.128.210.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A156A28466A; Tue, 2 Sep 2025 10:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.128.210.58 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756808730; cv=none; b=Focl+LprVnhkLeprMh9xi3I1uG6QSyfujmZUARGUQatVZu5reJblyTGD0khz4+NNt/LxWRsUHIEyA5MzFkJu4Ui1vdSjJcL4ZadOgccjupe5NLGu93r+8KZlIbvh4q1YCHCtd0u1wTg1m89NcSlVHOkWtiLQqDvm5o4zYBi9hJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756808730; c=relaxed/simple; bh=eJajwDH01kh3IPvaIJQpbt4glqzV/FP5xQlNld2ZALo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rMW9aoB4mhtLkzjD4oMz43eMkFd5XXi3udJ1KOq/X2QbBh/9dDrmTie5QWXwKnjy3jXmLp9cxLmytnHKkbZTXY8PZgTstiE0RoGqB9WIg7LWSbx8saMkiz+EY7XqntcVBJcjTOmcqFJcT35Xr8tqL6RNcg7evxJDGppwIvo+y88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=librecast.net; spf=pass smtp.mailfrom=librecast.net; arc=none smtp.client-ip=185.128.210.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=librecast.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=librecast.net Date: Tue, 2 Sep 2025 12:25:16 +0200 From: Brett Sheffield To: Paolo Abeni Cc: Oscar Maes , netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, dsahern@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net v4] selftests: net: add test for destination in broadcast packets Message-ID: References: <20250828114242.6433-1-oscmaes92@gmail.com> <03991134-4007-422b-b25a-003a85c1edb0@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2025-09-02 11:57, Paolo Abeni wrote: > > > On 9/2/25 11:33 AM, Brett Sheffield wrote: > > On 2025-09-02 10:49, Paolo Abeni wrote: > >> On 8/28/25 1:42 PM, Oscar Maes wrote: > >>> Add test to check the broadcast ethernet destination field is set > >>> correctly. > >>> > >>> This test sends a broadcast ping, captures it using tcpdump and > >>> ensures that all bits of the 6 octet ethernet destination address > >>> are correctly set by examining the output capture file. > >>> > >>> Signed-off-by: Oscar Maes > >>> Co-authored-by: Brett A C Sheffield > >> > >> I'm sorry for nit-picking, but the sob/tag-chain is wrong, please have a > >> look at: > >> > >> https://elixir.bootlin.com/linux/v6.16.4/source/Documentation/process/submitting-patches.rst#L516 > > > > Thanks Paolo. So, something like: > > > > Co-developed-by: Brett A C Sheffield > > Signed-off-by: Brett A C Sheffield > > Co-developed-by: Oscar Maes > > Signed-off-by: Oscar Maes > > > > with the last sign-off by Oscar because he is submitting? > > Actually my understanding is: > > Co-developed-by: Brett A C Sheffield > Signed-off-by: Brett A C Sheffield > Signed-off-by: Oscar Maes > > (if the patch is submitted by Oscar.) Basically the first examples in > the doc, with the only differences that such examples lists 3 co-developers. Ah yes, you are correct. I missed the "in addition to the author attributed by the From: tag" bit. Thanks again. Brett