From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9C642F39C2 for ; Wed, 3 Sep 2025 13:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756904705; cv=none; b=XW6ecm5DoG2LyIc/cwviJzvQR2Ty8j6+fW3J3OLoNyKNeuZCDlMHSHrGCQ2Pk92V7LZicpzb/BBFaTKrF1Nspr8BubCAvrUPlaPNKm3wN6MOhs2qZ39jys++61KpADK9F4Vm4gUT0eoxDAD6GWVMTO6pzqL4jMUrle+MEcj2hxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756904705; c=relaxed/simple; bh=oQdhtgDovuxi8JS+MCz16alo7u5trbBdBqt4kYDPGZM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sJMI0GLhJpWLQvbHS7ZsUwMaYjYApxF2wddnwJLRPFTlZbu66y2iqaW6YPup17Tmz3SovP2oaIrl3x4DGvjXq1BxHcwz16yerULmNS3wFrn+HJIrtpXYEswiyXDVQL/o/Gdh0UZpS7x2kQZq+J2Vnsf1UUbwaiatxxikoY/kHFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=aXhrCKnw; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="aXhrCKnw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=El/Xm4jDg9HBHpVGHlt56E3MYyMc4lLjk5+B4z84LHQ=; b=aXhrCKnwDwPyqgIkyh8xbWumNA bPACdkz1r6AIkAK/Zw40Q5DBIp/z2qW3NoY1WxV9QUemaGBM64DbKolPC/zl4T5gQAXj1BR7FXYGq 7KKUgn7U4EKE6m9A/fqCvttpXv+Yii43tk6MAc1K67AK/WYD6KMQW58Yyjuoi/iU9fdiW4qdR35w9 MJGI+6T5ZsDs5lza0HmSvHrlqeCzFrLIbQNn02SQvwa2IVYbLzLCdQDkoO8IoMhKjVhRLpF1P/+bw aAIRnjDCRAQPrARjfSIXjoXtqih5XId4N1802+vC/XO9ItWlijCoYwyyv3BTYDOU05qRXZdmyocGG dxBLcRIg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57812) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1utnAW-000000000Z2-3nVw; Wed, 03 Sep 2025 14:04:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1utnAU-000000000YK-22jm; Wed, 03 Sep 2025 14:04:54 +0100 Date: Wed, 3 Sep 2025 14:04:54 +0100 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 00/11] net: stmmac: mdio cleanups Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Wed, Sep 03, 2025 at 01:38:57PM +0100, Russell King (Oracle) wrote: > Hi, > > Clean up the stmmac MDIO code: > - provide an address register formatter to avoid repeated code > - provide a common function to wait for the busy bit to clear > - pre-compute the CR field (mdio clock divider) > - move address formatter into read/write functions > - combine the read/write functions into a common accessor function > - move runtime PM handling into common accessor function > - rename register constants to better reflect manufacturer names > - move stmmac_clk_csr_set() into stmmac_mdio > - make stmmac_clk_csr_set() return the CR field value and remove > priv->clk_csr > - clean up if() range tests in stmmac_clk_csr_set() > - use STMMAC_CSR_xxx definitions in initialisers It would be great if someone can test this series please. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!