netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts
@ 2025-09-02 15:40 Krzysztof Kozlowski
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-02 15:40 UTC (permalink / raw)
  To: Matthew Gerlach, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Romain Gantois,
	Geert Uytterhoeven, Magnus Damm, netdev, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel, linux-renesas-soc
  Cc: Krzysztof Kozlowski

STMMAC on SoCFPGA uses exactly one interrupt in in-kernel DTS and common
snps,dwmac.yaml binding is flexible, so define precise constraint for
this device.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Minor typo in commit msg.
---
 .../devicetree/bindings/net/altr,socfpga-stmmac.yaml       | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index 3a22d35db778..fc445ad5a1f1 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -62,6 +62,13 @@ properties:
       - const: stmmaceth
       - const: ptp_ref
 
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    items:
+      - const: macirq
+
   iommus:
     minItems: 1
     maxItems: 2
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: Constrain interrupts
  2025-09-02 15:40 [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts Krzysztof Kozlowski
@ 2025-09-02 15:40 ` Krzysztof Kozlowski
  2025-09-03  7:51   ` Romain Gantois
                     ` (3 more replies)
  2025-09-02 22:48 ` [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: " Matthew Gerlach
                   ` (2 subsequent siblings)
  3 siblings, 4 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-02 15:40 UTC (permalink / raw)
  To: Matthew Gerlach, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Romain Gantois,
	Geert Uytterhoeven, Magnus Damm, netdev, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel, linux-renesas-soc
  Cc: Krzysztof Kozlowski, Lad Prabhakar

Renesas RZN1 GMAC uses three interrupts in in-kernel DTS and common
snps,dwmac.yaml binding is flexible, so define precise constraint for
this device.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Minor typo in commit msg.
2. one->three interrupts in commit msg
3. Rb tag
---
 .../devicetree/bindings/net/renesas,rzn1-gmac.yaml       | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml
index d9a8d586e260..16dd7a2631ab 100644
--- a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml
@@ -30,6 +30,15 @@ properties:
       - const: renesas,rzn1-gmac
       - const: snps,dwmac
 
+  interrupts:
+    maxItems: 3
+
+  interrupt-names:
+    items:
+      - const: macirq
+      - const: eth_wake_irq
+      - const: eth_lpi
+
   pcs-handle:
     description:
       phandle pointing to a PCS sub-node compatible with
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts
  2025-09-02 15:40 [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts Krzysztof Kozlowski
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
@ 2025-09-02 22:48 ` Matthew Gerlach
  2025-09-03 16:40 ` Rob Herring (Arm)
  2025-09-03 22:40 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 9+ messages in thread
From: Matthew Gerlach @ 2025-09-02 22:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Romain Gantois,
	Geert Uytterhoeven, Magnus Damm, netdev, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel, linux-renesas-soc



On 9/2/25 8:40 AM, Krzysztof Kozlowski wrote:
> STMMAC on SoCFPGA uses exactly one interrupt in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Matthew Gerlach <matthew.gerlach@altera.com>

>
> ---
>
> Changes in v2:
> 1. Minor typo in commit msg.
> ---
>   .../devicetree/bindings/net/altr,socfpga-stmmac.yaml       | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index 3a22d35db778..fc445ad5a1f1 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -62,6 +62,13 @@ properties:
>         - const: stmmaceth
>         - const: ptp_ref
>   
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    items:
> +      - const: macirq
> +
>     iommus:
>       minItems: 1
>       maxItems: 2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: Constrain interrupts
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
@ 2025-09-03  7:51   ` Romain Gantois
  2025-09-03  9:18   ` Geert Uytterhoeven
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Romain Gantois @ 2025-09-03  7:51 UTC (permalink / raw)
  To: Matthew Gerlach, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue,
	Geert Uytterhoeven, Magnus Damm, netdev, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel, linux-renesas-soc,
	Krzysztof Kozlowski
  Cc: Krzysztof Kozlowski, Lad Prabhakar

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

Hi Krzysztof,

On Tuesday, 2 September 2025 17:40:53 CEST Krzysztof Kozlowski wrote:
> Renesas RZN1 GMAC uses three interrupts in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
> 
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Minor typo in commit msg.
> 2. one->three interrupts in commit msg
> 3. Rb tag
> ---
>  .../devicetree/bindings/net/renesas,rzn1-gmac.yaml       | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml
> b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml index
> d9a8d586e260..16dd7a2631ab 100644
> --- a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml
> @@ -30,6 +30,15 @@ properties:
>        - const: renesas,rzn1-gmac
>        - const: snps,dwmac
> 
> +  interrupts:
> +    maxItems: 3
> +
> +  interrupt-names:
> +    items:
> +      - const: macirq
> +      - const: eth_wake_irq
> +      - const: eth_lpi
> +
>    pcs-handle:
>      description:
>        phandle pointing to a PCS sub-node compatible with


LGTM.

Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: Constrain interrupts
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
  2025-09-03  7:51   ` Romain Gantois
@ 2025-09-03  9:18   ` Geert Uytterhoeven
  2025-09-03  9:45   ` Wolfram Sang
  2025-09-03 16:43   ` Rob Herring (Arm)
  3 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2025-09-03  9:18 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Matthew Gerlach, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Romain Gantois,
	Magnus Damm, netdev, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel, linux-renesas-soc, Lad Prabhakar

On Tue, 2 Sept 2025 at 17:41, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Renesas RZN1 GMAC uses three interrupts in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: Constrain interrupts
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
  2025-09-03  7:51   ` Romain Gantois
  2025-09-03  9:18   ` Geert Uytterhoeven
@ 2025-09-03  9:45   ` Wolfram Sang
  2025-09-03 16:43   ` Rob Herring (Arm)
  3 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2025-09-03  9:45 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Matthew Gerlach, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Romain Gantois,
	Geert Uytterhoeven, Magnus Damm, netdev, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel, linux-renesas-soc, Lad Prabhakar

On Tue, Sep 02, 2025 at 05:40:53PM +0200, Krzysztof Kozlowski wrote:
> Renesas RZN1 GMAC uses three interrupts in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
> 
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Double checked with the original RZ/N1 docs:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts
  2025-09-02 15:40 [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts Krzysztof Kozlowski
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
  2025-09-02 22:48 ` [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: " Matthew Gerlach
@ 2025-09-03 16:40 ` Rob Herring (Arm)
  2025-09-03 22:40 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-09-03 16:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Matthew Gerlach, netdev, Eric Dumazet, linux-renesas-soc,
	Geert Uytterhoeven, Jakub Kicinski, David S. Miller, Paolo Abeni,
	Magnus Damm, Krzysztof Kozlowski, Romain Gantois,
	Alexandre Torgue, linux-kernel, Maxime Coquelin, Andrew Lunn,
	devicetree, linux-stm32, linux-arm-kernel, Conor Dooley


On Tue, 02 Sep 2025 17:40:52 +0200, Krzysztof Kozlowski wrote:
> STMMAC on SoCFPGA uses exactly one interrupt in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Minor typo in commit msg.
> ---
>  .../devicetree/bindings/net/altr,socfpga-stmmac.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: Constrain interrupts
  2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
                     ` (2 preceding siblings ...)
  2025-09-03  9:45   ` Wolfram Sang
@ 2025-09-03 16:43   ` Rob Herring (Arm)
  3 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-09-03 16:43 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: linux-stm32, Jakub Kicinski, Conor Dooley, Lad Prabhakar,
	Romain Gantois, linux-arm-kernel, Eric Dumazet, linux-kernel,
	Matthew Gerlach, Andrew Lunn, netdev, linux-renesas-soc,
	David S. Miller, Krzysztof Kozlowski, Maxime Coquelin,
	Magnus Damm, Paolo Abeni, devicetree, Alexandre Torgue,
	Geert Uytterhoeven


On Tue, 02 Sep 2025 17:40:53 +0200, Krzysztof Kozlowski wrote:
> Renesas RZN1 GMAC uses three interrupts in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
> 
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Minor typo in commit msg.
> 2. one->three interrupts in commit msg
> 3. Rb tag
> ---
>  .../devicetree/bindings/net/renesas,rzn1-gmac.yaml       | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts
  2025-09-02 15:40 [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2025-09-03 16:40 ` Rob Herring (Arm)
@ 2025-09-03 22:40 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-03 22:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: matthew.gerlach, andrew+netdev, davem, edumazet, kuba, pabeni,
	robh, krzk+dt, conor+dt, mcoquelin.stm32, alexandre.torgue,
	romain.gantois, geert+renesas, magnus.damm, netdev, devicetree,
	linux-stm32, linux-arm-kernel, linux-kernel, linux-renesas-soc

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  2 Sep 2025 17:40:52 +0200 you wrote:
> STMMAC on SoCFPGA uses exactly one interrupt in in-kernel DTS and common
> snps,dwmac.yaml binding is flexible, so define precise constraint for
> this device.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> [...]

Here is the summary with links:
  - [v2,1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts
    https://git.kernel.org/netdev/net-next/c/f672fcd8e6c4
  - [v2,2/2] dt-bindings: net: renesas,rzn1-gmac: Constrain interrupts
    https://git.kernel.org/netdev/net-next/c/69cd99350740

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-09-03 22:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-02 15:40 [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: Constrain interrupts Krzysztof Kozlowski
2025-09-02 15:40 ` [PATCH v2 2/2] dt-bindings: net: renesas,rzn1-gmac: " Krzysztof Kozlowski
2025-09-03  7:51   ` Romain Gantois
2025-09-03  9:18   ` Geert Uytterhoeven
2025-09-03  9:45   ` Wolfram Sang
2025-09-03 16:43   ` Rob Herring (Arm)
2025-09-02 22:48 ` [PATCH v2 1/2] dt-bindings: net: altr,socfpga-stmmac: " Matthew Gerlach
2025-09-03 16:40 ` Rob Herring (Arm)
2025-09-03 22:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).