From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Marcin Wojtas <marcin.s.wojtas@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] net: mvneta: add support for hardware timestamps
Date: Tue, 9 Sep 2025 22:07:20 +0100 [thread overview]
Message-ID: <aMCXCPQryckcCR3g@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250909140113.3977f8ba@kernel.org>
On Tue, Sep 09, 2025 at 02:01:13PM -0700, Jakub Kicinski wrote:
> On Tue, 09 Sep 2025 16:30:01 +0100 Russell King wrote:
> > + /* FIXME: This is not really the true transmit point, since
> > + * we batch up several before hitting the hardware, but is
> > + * the best we can do without more complexity to walk the
> > + * packets in the pending section of the transmit queue.
> > + */
>
> That's true for all SW/driver timestamps I know of.
> No objection to keeping the comment, just a FWIW.
I'll drop the "FIXME:" prefix and re-send tomorrow with the
.get_ts_info() op filled in.
Thanks Jakub.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-09-09 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 15:30 [PATCH net-next] net: mvneta: add support for hardware timestamps Russell King
2025-09-09 16:17 ` Russell King (Oracle)
2025-09-09 21:00 ` Jakub Kicinski
2025-09-09 21:01 ` Jakub Kicinski
2025-09-09 21:07 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMCXCPQryckcCR3g@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=marcin.s.wojtas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).