From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b6-smtp.messagingengine.com (fout-b6-smtp.messagingengine.com [202.12.124.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C8532A80C; Wed, 10 Sep 2025 14:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757516280; cv=none; b=m6ecqS4YhJMboQ7W6Ne7nvCtKjHoieNP+Z/ZwcspE8Ndj0zNqSmNH7QkfwOEObIa2SJP6+9240k1B4IgAGk53ZRCEbo8s0scfUnq8akUjYBDHp4uZxxFGZb+LVQOvGRYLcZYUJ+w26yK3tBL9tfdVSBvStMcBvt4YzbQblmiPfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757516280; c=relaxed/simple; bh=Vln8dfg2bHZWodEg9nnmVYDAn8PzYG29tHd56gGL644=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fxf3FUIIrdx+ozgzw3m7Am9zq0cSh5L0ou+/pgf62jPsFs0aqEHEHK7B97RAO+ptcdgrnMa+P1ohBAPdXLtQzUWZdrtI9CC9/a+MMKarBz4L6jrjIwjRsmCtRG2B+QM+/Otuc9oNmuby9dB3A7613KTjGlakPk6xvrCJ+HoLlMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=sETkKnpY; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=CWpMje03; arc=none smtp.client-ip=202.12.124.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="sETkKnpY"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="CWpMje03" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 8B9101D0010A; Wed, 10 Sep 2025 10:57:57 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Wed, 10 Sep 2025 10:57:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1757516277; x= 1757602677; bh=fj2WWlUvdozMy73vBjpbx8CvlLfiX/DewG58TQUw/5s=; b=s ETkKnpYjusLWEXoNeNa85hC3l2VxvioJqMnlZncO4mSdlN+Wy+p5+Ptj8gHUegFo raapCNQ5PC/o3QDw348mEcBfPaEUZIHjrKTxqiDThr7tfBM2WjTaR8auX+H6xmH1 zXg1NNnFxlACbJyvM3Bmaz8uS2YluiGNZbMpIzc5E/E6Q3vEyYd8R/IuDnslBdiS /bvuf7U/GrH8k7jBRCBQMyAQ99JW62xuO35nn0CIfqRJZWzBB+aIvUCnOiYouY1c UwE2+xwwuxIFjZPCokJV7OQmM7KEqILW5xNLFUAhaBioHaDttHVqqyRkavgsvTIr +LAfQNeoo5W8NYP1v/pIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1757516277; x=1757602677; bh=fj2WWlUvdozMy73vBjpbx8CvlLfiX/DewG5 8TQUw/5s=; b=CWpMje03a6T5qWXd3hlOihHGuBovJsdC4Z3ADrG0anuP9M30tRM tqeWFgB/uXvh8hKOJapCnYNRjoSwoT3tEMKzoQv2j4/a5Ep8ycH1v0wcA5y9XRx5 C4027bqatCeUBIfcr1sYOtet7BOXcvQv9yewwWzxNv3H0smxF9wX7BnprXsRPm+G +n8QcAAc+8L4IWy6pyfcQ32TF6nyeNs+19FE05rOlzOQxiZsgYQD5HGGOFZIbaA8 bW13kS87FXfPPl+/1poalwZf15cqqAubeKtIy/9RZ+MQPp4SwiP94I2C6AotF0fa RxHmk+IjCviUseEiQvNp+tEdC/cavdK5p5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvfeehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttdejnecuhfhrohhmpefurggsrhhinhgr ucffuhgsrhhotggruceoshgusehquhgvrghshihsnhgrihhlrdhnvghtqeenucggtffrrg htthgvrhhnpeeuhffhfffgfffhfeeuiedugedtfefhkeegteehgeehieffgfeuvdeuffef gfduffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsugesqhhuvggrshihshhnrghilhdrnhgvthdpnhgspghrtghpthhtohepudekpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehlihhuhhgrnhhgsghinhesghhmrghilhdrtg homhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgt phhtthhopehjvhesjhhvohhssghurhhghhdrnhgvthdprhgtphhtthhopegrnhgurhgvfi donhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhl ohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpd hrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprggsvghn ihesrhgvughhrghtrdgtohhmpdhrtghpthhtohepjhhirhhisehrvghsnhhulhhlihdruh hs X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Sep 2025 10:57:55 -0400 (EDT) Date: Wed, 10 Sep 2025 16:57:54 +0200 From: Sabrina Dubroca To: Hangbin Liu Cc: netdev@vger.kernel.org, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Simon Horman , Ido Schimmel , Shuah Khan , Stanislav Fomichev , Stanislav Fomichev , Kuniyuki Iwashima , Alexander Lobakin , bridge@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCHv3 net-next 5/5] selftests/net: add offload checking test for virtual interface Message-ID: References: <20250909081853.398190-1-liuhangbin@gmail.com> <20250909081853.398190-6-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250909081853.398190-6-liuhangbin@gmail.com> 2025-09-09, 08:18:52 +0000, Hangbin Liu wrote: > +__check_offload() > +{ > + local dev=$1 > + local opt=$2 > + local expect=$3 > + > + ip netns exec "$ns" ethtool --json -k "$dev" | \ > + jq -r -e ".[].\"$opt\".active == ${expect}" >/dev/null Sorry Hangbin, I should have noticed this when we discussed the IPsec test, since the problem is similar for the other features set in netdev_compute_features_from_lowers: `ethtool -k` does not test the dev->*_features (mpls, vlan, etc) set in the new common function, it only checks dev->features and dev->hw_features. So this will not test the new function. -- Sabrina