From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, ncardwell@google.com, kuniyu@google.com,
dsahern@kernel.org, horms@kernel.org,
linux-kernel@vger.kernel.org,
Mina Almasry <almasrymina@google.com>
Subject: Re: [PATCH net-next] net: devmem: expose tcp_recvmsg_locked errors
Date: Wed, 10 Sep 2025 08:39:05 -0700 [thread overview]
Message-ID: <aMGbmaelbnvKymvB@mini-arch> (raw)
In-Reply-To: <20250909183550.5bcc71d2@kernel.org>
On 09/09, Jakub Kicinski wrote:
> On Mon, 8 Sep 2025 10:50:45 -0700 Stanislav Fomichev wrote:
> > if (err <= 0) {
>
> Should we change this condition to be err < 0, then?
> I don't see a path that'd return 0 but it's a bit odd to explicitly
> handle 0 here and then let it override copied.
As you say, we don't seem to be returning 0 from tcp_recvmsg_dmabuf, so
this is mostly about the readability. But makes sense overall, will
repost.
prev parent reply other threads:[~2025-09-10 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 17:50 [PATCH net-next] net: devmem: expose tcp_recvmsg_locked errors Stanislav Fomichev
2025-09-08 20:44 ` David Ahern
2025-09-09 18:05 ` Mina Almasry
2025-09-09 18:09 ` Eric Dumazet
2025-09-10 1:35 ` Jakub Kicinski
2025-09-10 15:39 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMGbmaelbnvKymvB@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).