From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/2] of: mdio: warn if deprecated fixed-link binding is used
Date: Thu, 11 Sep 2025 21:13:15 +0100 [thread overview]
Message-ID: <aMMtW0AlZ6kkjQQh@shell.armlinux.org.uk> (raw)
In-Reply-To: <5b3bc68c-fb1f-47ab-a6b0-8980c69fe068@gmail.com>
On Thu, Sep 11, 2025 at 09:19:26PM +0200, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - use %pOF printk specifier
> ---
> drivers/net/mdio/of_mdio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
> index d8ca63ed8..24e03f7a6 100644
> --- a/drivers/net/mdio/of_mdio.c
> +++ b/drivers/net/mdio/of_mdio.c
> @@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np)
> /* Old binding */
> if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
> ARRAY_SIZE(fixed_link_prop)) == 0) {
> + pr_warn_once("%pOF uses deprecated array-style fixed-link binding!",
Ditto.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-09-11 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 19:18 [PATCH net-next v2 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected Heiner Kallweit
2025-09-11 19:19 ` [PATCH net-next v2 1/2] of: mdio: warn if deprecated fixed-link binding is used Heiner Kallweit
2025-09-11 20:13 ` Russell King (Oracle) [this message]
2025-09-11 19:20 ` [PATCH net-next v2 2/2] net: phylink: warn if deprecated array-style " Heiner Kallweit
2025-09-11 20:12 ` Russell King (Oracle)
2025-09-12 5:31 ` [PATCH net-next v2 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected Heiner Kallweit
2025-09-12 23:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMMtW0AlZ6kkjQQh@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).