netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
	netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
	Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
	Shuah Khan <shuah@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Stanislav Fomichev <stfomichev@gmail.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	bridge@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv3 net-next 5/5] selftests/net: add offload checking test for virtual interface
Date: Fri, 12 Sep 2025 06:52:08 +0000	[thread overview]
Message-ID: <aMPDGCyoPwNTWNXq@fedora> (raw)
In-Reply-To: <cd37574b-0c15-481d-84dd-8ccc830efd06@redhat.com>

On Thu, Sep 11, 2025 at 05:41:24PM +0200, Paolo Abeni wrote:
> > For mpls_features, seem we only able to test NETIF_F_GSO_SOFTWARE, but I'm not
> > sure how to check mpls gso..
> > 
> > For hw_enc_features NETIF_F_HW_ESP. Does sending ipsec data and see if
> > netdevsim has pkts count enough??
> > 
> > Any advices? Should we just drop the selftest?
> 
> Uhm... one possible way of testing netdev_compute_features_from_lowers()
> correctness is transmitting over the relevant device (bridge/team/bond)
> "arbitrary" GSO packets and verify that the packet is segmented (or not)
> before reaching the lower.

Is there a way to check the packets are segmented over bond instead of lower devices?

> 
> GSO packet injection can be done with some work via the tun device (in
> tap mode), and the virtio hdr.

Do you mean tap over bond or bond over tap?
I don't know how to add tap over bond.
If bond over tap, then tap is the lower devices.
> 
> That is limited to some GSO types (i.e. no ipsec pkts), and can become
> easily very complex.
> 
> What about giving it a shot for UDP tunnel GSO types?

I'm not sure how to test tunnel + bond. Setup vxlan/ip tunnel over bond?

Thanks
Hangbin

      reply	other threads:[~2025-09-12  6:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  8:18 [PATCHv3 net-next 0/5] net: common feature compute for upper interface Hangbin Liu
2025-09-09  8:18 ` [PATCHv3 net-next 1/5] net: add a common function to compute features from lowers devices Hangbin Liu
2025-09-09  8:18 ` [PATCHv3 net-next 2/5] bonding: use common function to compute the features Hangbin Liu
2025-09-09  8:18 ` [PATCHv3 net-next 3/5] team: " Hangbin Liu
2025-09-10 15:31   ` Stanislav Fomichev
2025-09-11  1:46     ` Hangbin Liu
2025-09-09  8:18 ` [PATCHv3 net-next 4/5] net: bridge: " Hangbin Liu
2025-09-09  8:18 ` [PATCHv3 net-next 5/5] selftests/net: add offload checking test for virtual interface Hangbin Liu
2025-09-10 14:57   ` Sabrina Dubroca
2025-09-11  6:54     ` Hangbin Liu
2025-09-11 15:41       ` Paolo Abeni
2025-09-12  6:52         ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMPDGCyoPwNTWNXq@fedora \
    --to=liuhangbin@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jiri@resnulli.us \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=stfomichev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).