From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDECC338F55 for ; Mon, 15 Sep 2025 14:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757948076; cv=none; b=Wq9j8PtqQKRV5ocPMM5qfmpJmkzNcLfD5p0G/huvWAFPjbWvFpPFCXPrVQYc/bxQv1V/s0qQl6cOFXhbkAT7NvJr2MFGdSYy6sRu5jMhzjD3FnTzcGwGrap9Gc/En9aLOOfZUynEhpWCFkZre7VC/F64FpLi4J0YcI4CqxsKXZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757948076; c=relaxed/simple; bh=PS/pbmTRXcygzjKLV/ZriweIInnpNBJCFMpcte3A8mE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LZxkEZTPGLQEE/gJouG74Q3o/nOKAs+6va5uu8SoCtGeLYfvlKiFzFZbzfJjswNm0q2jm5UdPDVvpQHWc3V7rrxn2CMAXBO4pE6VUBhWpg3Uj4Ztmhn9fhJYudrxiC4qOadG9d5EcLJgxLZufL+CWcysZaCp8/K223zRSTRGXKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aXh5hcS1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aXh5hcS1" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58FDolFU018224 for ; Mon, 15 Sep 2025 14:54:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=TMSXgi/BqIZSCVKz3fftJI0C kUt1hfyDi31hmUWvWS0=; b=aXh5hcS14xPsBunpQrH8Eh5TQbDRg0PmqQNaHo/6 9S5xu31giH22C693vkM+MrT3c0BnZpy3kubiltEDzBV2AGFaDTZ2e/nUSAioudg6 2d7jOHE77Hdve05PsSQpNzaryB8ftWFlOBy6oW/FhYwB9w6zK0ifHxkKFoU6qedT s2yl9vDonKEeKN89fiswvww/SJVFcGrmiQhjFvE3zqD8PoCewii1RfrPc6a+w49x jDns2D3p+956O/I+QPrKrGO8xj8iDWtvsxhIIcDeCP5djCM37XNOHxj2m/kWt3YM DCO3tmL0Yc/pw35b7pddxCE7GWUkfsGfFek+YI1xAA2d6w== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4950u55a4f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 15 Sep 2025 14:54:34 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-24457ef983fso78046635ad.0 for ; Mon, 15 Sep 2025 07:54:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757948073; x=1758552873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TMSXgi/BqIZSCVKz3fftJI0CkUt1hfyDi31hmUWvWS0=; b=FO+tD3CA/2VS4F5d7LrsevkbcypPkBALUK5V2KIklq38qqHoUMheBeYYZEbcVgEsbC 2ttCSDBdSaRk6eKUCU6Z4FAB8NY716ZE5vyGQAdZFqKvnRneLpveFF7jqZzRdwBh8Z6K E7zoBZuKXJJ1U6KKCCCfqFK9yzKCtGYM/2wX8QNfqDy5VjnAZefHZoeSKZozk1L155Ml yEkncUwPurLuIX5/AVGoEEnS63ZrPpVxVs7kEK/Zf1s+5I2gaYkRLQkqeLYMG/IyAhBp R+PzDQIwZFkFBDOcGQLpp7VrTr5nTWvnHjoGgbz3eYFrvUHPhARl4ezonTZlUcQo6lWo VZmw== X-Forwarded-Encrypted: i=1; AJvYcCUxPKxV3nMi7UumzagM/Fyy5bZ7jLHDtHNZKNt9NTDRCL1tX/YHbXNjW7aHpqn249w49gXqspY=@vger.kernel.org X-Gm-Message-State: AOJu0YzIwFFDB3HQ84L1g2r5M50dqqikv+lmZ4y/QXFhTlksTVA0lFka IY4v0iVIx03V6sRz+drUHV3YJdWAB63dyGFKghIVifV5C8Lznk1o9VeAb44/wdGmvH3L+bF/5iZ Vwy2H2IFl6C9K/Rqi52k1YMUw1NfAoyd0JBNmNBpl9HuxQYzO9PLPA66GXew= X-Gm-Gg: ASbGnct/l4Qwf3RT+NF39AVuILC0oynsfet1NxaD3Y6HNGMItmVCLbQn9Hw9IjhLSDz l9eI/4jOLveLM85+32qjJxQy9xCUup2+kY9y6dsof5yrfiWqVO4NzZLpSAbe/Ey1Rnu4Fr4fJaD ILvxmIprgZ46vcK4V6QOjOQcTeBkdAe8Q+Mk6rzPbJQhJPStbtc+jpe3gyjsYjM/Uq/t1I8asHl EWqqp4XSgZnI4zVGf0nZZOJyOeVJgN9UEHtFFQR9LZNPjzsuGVEDyZeQMYeoRqCsZ8C1HS7Tm/t CYanugbB3f1BiWPRUPNpEp8bp5QBYFTuAxdj1VPKurQgrJEm9yFBig== X-Received: by 2002:a17:903:1b28:b0:24d:4d8b:a17 with SMTP id d9443c01a7336-25d27929650mr163440535ad.56.1757948073173; Mon, 15 Sep 2025 07:54:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHoNwqnfXJFToAd40yGFcgFxbZGcyYvpuu1gaAnNng/OHoz50BZQe6dvr+nmCY5nQscoatjSw== X-Received: by 2002:a17:903:1b28:b0:24d:4d8b:a17 with SMTP id d9443c01a7336-25d27929650mr163440125ad.56.1757948072624; Mon, 15 Sep 2025 07:54:32 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-26628eddb09sm35094205ad.59.2025.09.15.07.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 07:54:32 -0700 (PDT) Date: Mon, 15 Sep 2025 20:24:26 +0530 From: Mohd Ayaan Anwar To: "Russell King (Oracle)" Cc: andrew@lunn.ch, Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: qcom: qca808x: Add .get_rate_matching support Message-ID: References: <20250914-qca808x_rate_match-v1-1-0f9e6a331c3b@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: ALUJ-IghZf_fteXF2CPST6URAxc-UQ8h X-Proofpoint-ORIG-GUID: ALUJ-IghZf_fteXF2CPST6URAxc-UQ8h X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDAzMSBTYWx0ZWRfX0QzpVzAQdDdB g3QyhFtAXwXKSAvP7SWbjYhGuMv0HCX9IX7Rs7SoPElqf467nqm2Ye9BOqwYkl4nZhaPGHbCsZO 14EE21WC8HPa3Pp+Jb81zye0BdFiloY9Cjhwekuif4uuXF7DldAPxxKbJIVvMXoogy2FG4WkOb4 qNyPJ/NcaiP6Tr5p0zuVnGHQRB2uGAaw7S6redEeciRWzafNqS/5O0xztjuzZeE90JlCRi13EkI fpYoRat5AFolcSwZE7KzK61dwcE11BmyVn81vmBao3tv7UxWqHx30BZNpLJkJeOgYvVzLcQatEX Do9yaRThxOJu7VfxjdM3nDJZX8BtVU0SDaorF9NcCyaT+qcANCSALwU6zZX9mIVsqAmsj7DxJJf g87l0skY X-Authority-Analysis: v=2.4 cv=JvzxrN4C c=1 sm=1 tr=0 ts=68c828aa cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=Tu3KNy09MRMvIius73gA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-15_06,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130031 On Mon, Sep 15, 2025 at 01:09:39PM +0100, Russell King (Oracle) wrote: > This shows that the PHY supports SGMII (4) and 2500base-X (23). However, > as we only validate 2500base-X, this suggests stmmac doesn't support > switching between SGMII and 2500base-X. > > What *exactly* is the setup with stmmac here? Do you have an external > PCS to support 2500base-X, or are you using the stmmac internal PCS? Internal PCS. But it's not really pure 2500base-X... I found an older thread for this exact MAC core [0], and it looks like we have an overclocked SGMII, i.e., 2500base-X without in-band signalling. Just wondering if registering a `.get_interfaces` callback in `dwmac-qcom-ethqos.c` and doing something like the following will be helpful? case PHY_INTERFACE_MODE_2500BASEX: __set_bit(PHY_INTERFACE_MODE_2500BASEX, interfaces); fallthrough; case PHY_INTERFACE_MODE_SGMII: __set_bit(PHY_INTERFACE_MODE_SGMII, interfaces); break; ... This should ensure that both SGMII and 2500base-X are validated, allowing switching between them. Ayaan --- [0] https://lore.kernel.org/netdev/4f642463-3a8c-4412-a007-42fb65c4276e@lunn.ch/