From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>, Petr Machata <petrm@nvidia.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bonding: fix xfrm offload feature setup on active-backup mode
Date: Tue, 16 Sep 2025 02:58:31 +0000 [thread overview]
Message-ID: <aMjSVwIv7f9VDvHL@fedora> (raw)
In-Reply-To: <20250915184123.505d2bb8@kernel.org>
On Mon, Sep 15, 2025 at 06:41:23PM -0700, Jakub Kicinski wrote:
> On Mon, 15 Sep 2025 08:37:41 +0000 Hangbin Liu wrote:
> > The active-backup bonding mode supports XFRM ESP offload. However, when
> > a bond is added using command like `ip link add bond0 type bond mode 1
> > miimon 100`, the `ethtool -k` command shows that the XFRM ESP offload is
> > disabled. This occurs because, in bond_newlink(), we change bond link
> > first and register bond device later. So the XFRM feature update in
> > bond_option_mode_set() is not called as the bond device is not yet
> > registered, leading to the offload feature not being set successfully.
> >
> > To resolve this issue, we can modify the code order in bond_newlink() to
> > ensure that the bond device is registered first before changing the bond
> > link parameters. This change will allow the XFRM ESP offload feature to be
> > correctly enabled.
>
> This reportedly doesn't apply.. I suppose we want it to go via net?
Ah, yes. I forgot to add the target repo. I need to write a git format-patch
wrapper to remind me adding it...
Regards
Hangbin
prev parent reply other threads:[~2025-09-16 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 8:37 [PATCH 1/2] bonding: fix xfrm offload feature setup on active-backup mode Hangbin Liu
2025-09-15 8:37 ` [PATCH 2/2] selftests: bonding: add ipsec offload test Hangbin Liu
2025-09-16 1:41 ` [PATCH 1/2] bonding: fix xfrm offload feature setup on active-backup mode Jakub Kicinski
2025-09-16 2:58 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMjSVwIv7f9VDvHL@fedora \
--to=liuhangbin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).