From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 067F223B60C for ; Tue, 16 Sep 2025 02:58:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757991520; cv=none; b=OSbbUm7NzOQ8fww5Jh2Kvctw0+12aGrjwE0cgEMmnrwGq88CCLTCmPQQ/yualDb9Ntud/KTsm9NryVT8uzcw3cPe+jSdieuywJ/u0cnrBqkXobqYCgW0wvTYDUsgSGXq/do8yEC/xqdmAoCn0k5uRf/+e5fcP+9bdjWBvIvsfcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757991520; c=relaxed/simple; bh=7XO66tFZ7sDtnbhU8FMTHuC7bAcZAOuj24LDeP0n+JU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nJYH1nSh/8UK2V3tlO+dSaHRPVRO28Aq3U2N6kqt06MwPSQrVzDQNShBkTNxzg9DIciWIwxMt3Zc++4gXHP0mTXMKZxo5aUclD+jp42kyxVEgj1BCqgcl+0jBOK4FbEPyx5PHn4E0Y5bN0QJyxISnIW//uFm0YkSllxWZRqncd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kxEVaw8b; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxEVaw8b" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-267a5aeb9f1so8683515ad.1 for ; Mon, 15 Sep 2025 19:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757991518; x=1758596318; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aQgTdWvdAbQBkxXTr6NMR0psWz9YegO9W+coZ5goAHs=; b=kxEVaw8bf9vuBlp2ZbMHx8xvRrOnKLl+SRELST874YRW/9R3lKOjE/oU/DTMwJGFyy 5JWfUEs3HyfDMASVLzU89WA3Rvf1zazHsutNSDv6IvGT8tHh8Y6Ce7sV+U6aR3i+nILF OoHJs3AaXDfhtTWQMWQFVho3Gn1UTBFbe4A5FYns3rHUiZWnj2DIqBSybEOW0aKF3Byq kJ06WrhU+MM6j+8SdWeELVVLnmSaSQchi4RyNLXRfU9W6v3biM6PJN5B7sivChPDJGLs ugt56e6+7MwX4UVxcJQjL2Lq0Doz0W4sXWs7eTI1VbUCpeMJdpdzavEZB9kRnAhPDo4q r8rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757991518; x=1758596318; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aQgTdWvdAbQBkxXTr6NMR0psWz9YegO9W+coZ5goAHs=; b=pWSpdwbZ4632ilXAfyTeIjvx2DrPyy+btbNcCo0bIvyY1DpTPjwzc6Dn3DS7flDy6y 5/km3m3Gn5tGOoLOd65chYXT/58KxM3yylEL+qbf4dVS6xCD8di58e7e660VlX2gzWIr KJIvV3HYwZK8TxO3HPjgquSKkxvalNhIUhh1H6NjqM4ks2KP/OntEMQULEw1AA+SmmF6 J+LiaZtQ5Qo1yW1OHEaLyb2JM7Z8IaTN+iRUtAwA0GaK9wX83BFMxDdHif0wJKuN88VD GfhdF9R2XJ2UJuO+5Nm2SGn3jPDtf++JbRNT4bWxzA2KO8sZg4aHU/Npo8A5JwGnz7eP gmEw== X-Gm-Message-State: AOJu0Yy5OGSIeBOeUVSGwThx9k4onz8l6zRST416LvLWazamlB7qscyO V4kZ5s/YTxeNh8hkJT77iO6aHy8Pzm1ajCZDwsxCqm9yLbjDTIfxthI9 X-Gm-Gg: ASbGnctbKMbDrL97QfFKZ91S7qX2+g78VGuk4C6YtJDtk7nvBuafOiJYr9clAGbbFiK EAQ7Eh3c5Qq/AG0uPBm5ZKBWESTry+j9qmq6mMT1FBdoUyV2rmGHIAXZBt3ArDIP5i/n3KyF7We 6Nn6KUBqw2Dz7HslTOChUYByELePhuvPbTZUZAhZ1tZwqPP8zUulc98gxbT1c/rsxoxFGQlhHhh T0wlsx3lxwmKvB2F/drN7j58xNxbxv/2lHWbZkFHWkFetcT6+ASsX4/C3Ye7LE3S77Zy5fJD1EN ed4PTeL1VGdmQ7Ub2Oj6ZeV9WYcQh56OS2tlWRlgcnhAcj0zVcJOiQQtzKJk6NLfNl2eyQP1Abs ujKRJ18Fr2oB5NxOKhJvGQ5M/zkkKYm42lopHLg== X-Google-Smtp-Source: AGHT+IEpu9RPplREq+3dMnA9cO4wkDr5H7kfF9jU5qM/IUS4/1bFfNRe4izqZKvwQuiVIt05YcDmPQ== X-Received: by 2002:a17:903:388b:b0:250:6d0e:1e40 with SMTP id d9443c01a7336-25d242f2f14mr151186285ad.7.1757991518269; Mon, 15 Sep 2025 19:58:38 -0700 (PDT) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-267b0bbabe6sm22016895ad.107.2025.09.15.19.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Sep 2025 19:58:37 -0700 (PDT) Date: Tue, 16 Sep 2025 02:58:31 +0000 From: Hangbin Liu To: Jakub Kicinski Cc: netdev@vger.kernel.org, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Shuah Khan , Petr Machata , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] bonding: fix xfrm offload feature setup on active-backup mode Message-ID: References: <20250915083742.423741-1-liuhangbin@gmail.com> <20250915184123.505d2bb8@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250915184123.505d2bb8@kernel.org> On Mon, Sep 15, 2025 at 06:41:23PM -0700, Jakub Kicinski wrote: > On Mon, 15 Sep 2025 08:37:41 +0000 Hangbin Liu wrote: > > The active-backup bonding mode supports XFRM ESP offload. However, when > > a bond is added using command like `ip link add bond0 type bond mode 1 > > miimon 100`, the `ethtool -k` command shows that the XFRM ESP offload is > > disabled. This occurs because, in bond_newlink(), we change bond link > > first and register bond device later. So the XFRM feature update in > > bond_option_mode_set() is not called as the bond device is not yet > > registered, leading to the offload feature not being set successfully. > > > > To resolve this issue, we can modify the code order in bond_newlink() to > > ensure that the bond device is registered first before changing the bond > > link parameters. This change will allow the XFRM ESP offload feature to be > > correctly enabled. > > This reportedly doesn't apply.. I suppose we want it to go via net? Ah, yes. I forgot to add the target repo. I need to write a git format-patch wrapper to remind me adding it... Regards Hangbin