From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D454F248F7D for ; Tue, 16 Sep 2025 13:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758027917; cv=none; b=sIlLHHQl+iXwKz8rmqtCHOvFnljY4UXpqVAGro+kq4nzWXwaTbsqQmDP0JGJsCXKlHZ8H+A44yBYBMkcuYwgzcA0i3ZnjMAwKknO+a5kRWyNhE+XgFFfEJDjyC5+4xnkACmfMIhCoEXaCRxCzzuQ/xV4+hitIKbWAAWXXCxaGw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758027917; c=relaxed/simple; bh=A3J/tFGOFdBX0jXW1C50S6raOvMVBUSgWZvi7Kanhlc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rePLF3aA70keZCTVrVDjOrJQfRayrkfhgw+vshzNdP9NvX1frHOAM6vUVFWK5Efq8cevYb7gTinaOjBwXBw2S2qrbVEXZI9BpAQc7Djpvt31zxpzLPXHaCwDNibWjBu1ZiJAFJIVYJI9P0wnL6i53FnxFG32dPZ5y7UxqK1rP7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fos5Uf5H; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fos5Uf5H" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5632630dd04so878004e87.1 for ; Tue, 16 Sep 2025 06:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758027913; x=1758632713; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7/8TL00Hlar3x8JkbaIO/sy+q7FGgNPnwJ9JADaoRL4=; b=fos5Uf5HmtyHtL+lmjA3a2H9HrHhg8P/6Oolr9AJUDGP9OMkPBwjrxX4OljDwPgr6d EGU3mAK2k3oxuwsvYOcV9dbWMOzECSpFh5rGQAoVPBdCYGIzcxU1qmZg5zk4kcKy1o8m ObLceXCuhryPZVREmWltfaDyU3ZSF1AB8tcM7qcx3s+Gz+c2nfs8LaVe1SpP50rIkaBH 5kjixBwE/ipFb5iKq7VUmS/Jj4sUhCRs8m+4ruHcLezKuG1xEXn3RG6EeIVEcmOnGCUs 3gWXyvDwyTqCB2iiTAz4a69UtfssPH55UjmP+s5EQSAjGrj7AA9BVG9u3gT7Ox6W1DjG Y+8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758027913; x=1758632713; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7/8TL00Hlar3x8JkbaIO/sy+q7FGgNPnwJ9JADaoRL4=; b=JXPRGAAeW0fidRwRCq1Y2Seez2pqbYI2kZPLS5GqD4AHSDh+razyp1/RP6bsGLQf0n xBAQfiJTjm2al7P0ffxnMxDuaON9nVL69OZhjQSWvyq7TvJUTkwUyfadBdrihn3BJIee f/XXsdZxyK9zLQ023ceqex5GgJWm0keMc2E3syjtfdij8AIBWx+isiK4vYbPnS+aEXgl 26PzwqH6f8FQEBxyyXBBsa9PKkjnNsknGTJGSHsAkB5Ew+vznHittoTHcZ+KT94FqniE Cl1F/duyUmgCPCWNlhzrhChXx0ldM27Q0yBUloAlw/FwLe0sKT9UNssxhXuKdU5ziXFL +AOA== X-Forwarded-Encrypted: i=1; AJvYcCVRV/nqOYprTflMfqrEGxFvEQvppoYN96Re+TJVe7VlyXQRXeC7EeCatk5xarjPwPu+e0zApWY=@vger.kernel.org X-Gm-Message-State: AOJu0YzRayJDioZX1HoGRqOQ6ludcLidflJSZjiXCDbEyKf0LFMrltKF g1dXZ1GKWsX3i8LINNFtXgfVRwhY54K3b4M19oj+C1jLvJDQ+2j4utCnJ1JQhZ7+2fY= X-Gm-Gg: ASbGncsxUQeI1E+75PpfpOuAKHhckbmhbrNWqRGjmUf/q3ufg/KgO0aI4x6eKD67GYU 0/zAmxJEky2HtGUO7IvkwsJQJX5X0Y0usaeJU5i7i2cFd4gD9YKA2B7fiC9eEKi9hVHxzSCxCLj d2GzxeH8qrStQfrWwScewO0tCITbrBKkhLU9d8YgF/8KKwAMmDR4OCN9k/Cqo4Ubt/6O2InMYt0 IP9O0ZGx73D+25656wZ+MjqyExxxUT5z2Epeg/McMKI4lo6YxY7D1thMsKfJ5iduEXyfP2C+sxv NSAwKrY9qCxk44gAS7ILYrcJ79blG4Sq9H3mA+9jsAzEGUKdGHT2Mh+sPnkVi7VuHRjAWArXa44 PQvSqmEPShYAz7RMBgyz7moEzmptVoo7tDbp1o5HZT1InINC2LHLzX2GJpC/e00OUGQ== X-Google-Smtp-Source: AGHT+IENshuIe1ZzBTlZI8ErHAIWfYofEIxwEqD/DxJUwphDcoj5NYeMYiaSJpT5gnIx28eNAX2rmA== X-Received: by 2002:a2e:bea2:0:b0:336:e445:92c5 with SMTP id 38308e7fff4ca-3513dd54c2amr23580931fa.3.1758027912735; Tue, 16 Sep 2025 06:05:12 -0700 (PDT) Received: from monster (c-85-229-7-191.bbcust.telenor.se. [85.229.7.191]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-34f1b2a931fsm33599691fa.47.2025.09.16.06.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Sep 2025 06:05:10 -0700 (PDT) Date: Tue, 16 Sep 2025 15:05:07 +0200 From: Anders Roxell To: Prabhakar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Philipp Zabel , Russell King , Geert Uytterhoeven , Magnus Damm , Vladimir Oltean , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Biju Das , Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH net-next v3 3/3] net: stmmac: dwmac-renesas-gbeth: Add support for RZ/T2H SoC Message-ID: References: <20250908105901.3198975-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20250908105901.3198975-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250908105901.3198975-4-prabhakar.mahadev-lad.rj@bp.renesas.com> On 2025-09-08 11:59, Prabhakar wrote: > From: Lad Prabhakar > > Extend the Renesas GBETH stmmac glue driver to support the RZ/T2H SoC, > where the GMAC is connected through a MIIC PCS. Introduce a new > `has_pcs` flag in `struct renesas_gbeth_of_data` to indicate when PCS > handling is required. > > When enabled, the driver parses the `pcs-handle` phandle, creates a PCS > instance with `miic_create()`, and wires it into phylink. Proper cleanup > is done with `miic_destroy()`. New init/exit/select hooks are added to > `plat_stmmacenet_data` for PCS integration. > > Update Kconfig to select `PCS_RZN1_MIIC` when building the Renesas GBETH > driver so the PCS support is always available. > > Signed-off-by: Lad Prabhakar > --- > v2->v3: > - Dropped passing STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP flag in stmmac_flags > as it is always set for all the SoCs. > - Updated Kconfig to include RZ/T2H and RZ/N2H. > > v1->v2: > - No changes. The following warning is seen when doing a defconfig build (make defconfig) for arm64 on the Linux next-20250915 tag. First seen on next-20250915 Good: next-20250912 Bad: next-20250915 Regression Analysis: - New regression? yes - Reproducibility? yes Build regression: WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC Reported-by: Linux Kernel Functional Testing This is the build warning: WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC Depends on [n]: NETDEVICES [=y] && OF [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST [=n]) Selected by [m]: - DWMAC_RENESAS_GBETH [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_STMICRO [=y] && STMMAC_ETH [=m] && STMMAC_PLATFORM [=m] && OF [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) WARNING: unmet direct dependencies detected for PCS_RZN1_MIIC Depends on [n]: NETDEVICES [=y] && OF [=y] && (ARCH_RZN1 [=n] || COMPILE_TEST [=n]) Selected by [m]: - DWMAC_RENESAS_GBETH [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_STMICRO [=y] && STMMAC_ETH [=m] && STMMAC_PLATFORM [=m] && OF [=y] && (ARCH_RENESAS [=y] || COMPILE_TEST [=n]) I: config: PASS in 0:00:01.592356 By reverting this patch the warning disapears. ## Source * Kernel version: 6.17.0-rc6 * Git tree: * https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git * Git describe: next-20250915 * Git commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e * Architectures: arm64 * Toolchains: gcc and clang * Kconfigs: lkftconfigs ## Build * Build log: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UF8KltAzu6kUpW3hXaYRWjZ/build.log * Test details: https://regressions.linaro.org/lkft/linux-next-master/next-20250915/log-parser-build-clang/general-unmet-dependencies-warning-unmet-direct-dependencies-detected-for-pcs_rzn_miic/ * Build link: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UF8KltAzu6kUpW3hXaYRWjZ/ * Kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/32l4UF8KltAzu6kUpW3hXaYRWjZ/config -- Linaro LKFT