From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Wei Fang <wei.fang@nxp.com>
Cc: Ajay Kaher <ajay.kaher@broadcom.com>,
Alexey Makhalov <alexey.makhalov@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
David Woodhouse <dwmw2@infradead.org>,
Eric Dumazet <edumazet@google.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nick Shi <nick.shi@broadcom.com>, Paolo Abeni <pabeni@redhat.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
"Y.B. Lu" <yangbo.lu@nxp.com>
Subject: Re: [PATCH net-next 2/2] ptp: rework ptp_clock_unregister() to disable events
Date: Tue, 16 Sep 2025 14:38:23 +0100 [thread overview]
Message-ID: <aMloTwObRUIRAzPF@shell.armlinux.org.uk> (raw)
In-Reply-To: <PAXPR04MB851098C0A69B74DD232071B68814A@PAXPR04MB8510.eurprd04.prod.outlook.com>
On Tue, Sep 16, 2025 at 09:03:17AM +0000, Wei Fang wrote:
> > the ordering of ptp_clock_unregister() is not ideal, as the chardev
> ^
> Nit: Uppercase, 't' -> 'T'
>
> > +void ptp_disable_all_pins(struct ptp_clock *ptp)
> > +{
> > + struct ptp_clock_info *info = ptp->info;
> > + unsigned int i;
> > +
> > + mutex_lock(&ptp->pincfg_mux);
>
> Currently ptp_chardev.c has been converted to use the auto-cleanup
> API (scoped_cond_guard()), so scoped_guard() can be used here.
... which are very non-C like, non-obvious, and I currently have no
idea at the moment how to use it. In my opinion, it makes code more
difficult to understand.
Maybe someone else can convert this for me to this non-C like
structure?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-09-16 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 14:41 [PATCH net-next 0/2] ptp: safely cleanup when unregistering a PTP clock Russell King (Oracle)
2025-09-15 14:42 ` [PATCH net-next 1/2] ptp: describe the two disables in ptp_set_pinfunc() Russell King (Oracle)
2025-09-16 10:37 ` Vladimir Oltean
2025-09-16 12:44 ` Vadim Fedorenko
2025-09-15 14:42 ` [PATCH net-next 2/2] ptp: rework ptp_clock_unregister() to disable events Russell King (Oracle)
2025-09-16 9:03 ` Wei Fang
2025-09-16 13:38 ` Russell King (Oracle) [this message]
2025-09-16 14:38 ` Andrew Lunn
2025-09-16 13:02 ` Vadim Fedorenko
2025-09-16 15:45 ` Russell King (Oracle)
2025-09-16 16:20 ` Vadim Fedorenko
2025-09-16 19:46 ` Russell King (Oracle)
2025-09-16 21:22 ` Russell King (Oracle)
2025-09-16 8:37 ` [PATCH net-next 0/2] ptp: safely cleanup when unregistering a PTP clock Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMloTwObRUIRAzPF@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ajay.kaher@broadcom.com \
--cc=alexey.makhalov@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.shi@broadcom.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=svens@linux.ibm.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).