From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com, jacob.e.keller@intel.com,
Robert Marko <robert.marko@sartura.hr>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: sparx5/lan969x: Add support for ethtool pause parameters
Date: Wed, 17 Sep 2025 15:26:03 +0100 [thread overview]
Message-ID: <aMrE-9rtW20A9Xnj@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250917-802-3x-pause-v1-1-3d1565a68a96@microchip.com>
On Wed, Sep 17, 2025 at 01:49:43PM +0200, Daniel Machon wrote:
> Implement get_pauseparam() and set_pauseparam() ethtool operations for
> Sparx5 ports. This allows users to query and configure IEEE 802.3x
> pause frame settings via:
>
> ethtool -a ethX
> ethtool -A ethX rx on|off tx on|off autoneg on|off
>
> The driver delegates pause parameter handling to phylink through
> phylink_ethtool_get_pauseparam() and phylink_ethtool_set_pauseparam().
>
> The underlying configuration of pause frame generation and reception is
> already implemented in the driver; this patch only wires it up to the
> standard ethtool interface, making the feature accessible to userspace.
>
> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
It is nice to see drivers not having to implement complicated code
to add support for pause configuration!
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-09-17 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 11:49 [PATCH net-next] net: sparx5/lan969x: Add support for ethtool pause parameters Daniel Machon
2025-09-17 14:26 ` Russell King (Oracle) [this message]
2025-09-18 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMrE-9rtW20A9Xnj@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).