From: Lukas Wunner <lukas@wunner.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Hubert Wi??niewski <hubert.wisniewski.25632@gmail.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
stable@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Russell King <linux@armlinux.org.uk>, Xu Yang <xu.yang_2@nxp.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2 1/1] net: usb: asix: hold PM usage ref to avoid PM/MDIO + RTNL deadlock
Date: Wed, 1 Oct 2025 15:10:14 +0200 [thread overview]
Message-ID: <aN0oNgEp08BaGeTJ@wunner.de> (raw)
In-Reply-To: <20251001130432.2444863-1-o.rempel@pengutronix.de>
On Wed, Oct 01, 2025 at 03:04:32PM +0200, Oleksij Rempel wrote:
> @@ -1600,6 +1624,10 @@ static struct usb_driver asix_driver = {
> .resume = asix_resume,
> .reset_resume = asix_resume,
> .disconnect = usbnet_disconnect,
> + /* usbnet will force supports_autosuspend=1; we explicitly forbid RPM
> + * per-interface in bind to keep autosuspend disabled for this driver
> + * by using pm_runtime_forbid().
> + */
Looks like this code comment needs an update, now that you're no longer
using pm_runtime_forbid()?
Thanks,
Lukas
prev parent reply other threads:[~2025-10-01 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 13:04 [PATCH net v2 1/1] net: usb: asix: hold PM usage ref to avoid PM/MDIO + RTNL deadlock Oleksij Rempel
2025-10-01 13:10 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN0oNgEp08BaGeTJ@wunner.de \
--to=lukas@wunner.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hubert.wisniewski.25632@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).