From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D6DC1DA62E; Wed, 1 Oct 2025 13:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759324825; cv=none; b=u0onedwJOMT0xigUuP5J14/FPWV68PLtVTCuXO5XslnP4DJ6yUXgjHej/WgfYqJP9kxEL27eqqbQr80GqJB/Ii79UhjwjYPeksqNmWiWNtGYDxgf6HD5+OvpMJ7UwAy5p53oGgDck5giISkZP/Vpt6NYmrHvHXiE/EwfIFWqfvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759324825; c=relaxed/simple; bh=Uctcsfz4nNrfaQk5rKvvDsfcCV9RMgYtVLuLHqiRaLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SjjEXakmwiyeDxSVhhJ1vnQf/HCvVvHX90NddnkrlJx2DUJuSUa/ELynAQz3so7kA4L1lGZ/PU3KXcDHyG93BgrvbZJ86b28Vc/Km5l3qCSYfQKIaIBqTvFRyeBZ6Mq0X/6hOSoJSZ0iuRFAkFU7KSPrngH+ts+hCQEOuGqRi2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 621F82C0A2C6; Wed, 1 Oct 2025 15:10:14 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 4BEE65F82FE; Wed, 1 Oct 2025 15:10:14 +0200 (CEST) Date: Wed, 1 Oct 2025 15:10:14 +0200 From: Lukas Wunner To: Oleksij Rempel Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hubert Wi??niewski , Marek Szyprowski , stable@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King , Xu Yang , linux-usb@vger.kernel.org Subject: Re: [PATCH net v2 1/1] net: usb: asix: hold PM usage ref to avoid PM/MDIO + RTNL deadlock Message-ID: References: <20251001130432.2444863-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251001130432.2444863-1-o.rempel@pengutronix.de> On Wed, Oct 01, 2025 at 03:04:32PM +0200, Oleksij Rempel wrote: > @@ -1600,6 +1624,10 @@ static struct usb_driver asix_driver = { > .resume = asix_resume, > .reset_resume = asix_resume, > .disconnect = usbnet_disconnect, > + /* usbnet will force supports_autosuspend=1; we explicitly forbid RPM > + * per-interface in bind to keep autosuspend disabled for this driver > + * by using pm_runtime_forbid(). > + */ Looks like this code comment needs an update, now that you're no longer using pm_runtime_forbid()? Thanks, Lukas