From: Florian Westphal <fw@strlen.de>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux.dev
Subject: Re: [PATCH v15 nf-next 2/3] netfilter: bridge: Add conntrack double vlan and pppoe
Date: Thu, 2 Oct 2025 10:11:56 +0200 [thread overview]
Message-ID: <aN4zzDvdJKjRxdnt@strlen.de> (raw)
In-Reply-To: <20250925183043.114660-3-ericwouds@gmail.com>
Eric Woudstra <ericwouds@gmail.com> wrote:
> This adds the capability to conntrack 802.1ad, QinQ, PPPoE and PPPoE-in-Q
> packets that are passing a bridge, only when a conntrack zone is set.
I got no more comments for the patch itself, but this commit message
needs more information.
Why are you adding this?
Why the conntrack zone constraint?
Also, I don't think this conntracks 802.1ad etc. at all, it tracks
connections carried inside these L2 encapsulations rather than
just plain ip(v6) in ethernet.
... and again, why would one do that, i.e. whats the purpose of this
patch?
next prev parent reply other threads:[~2025-10-02 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 18:30 [PATCH v15 nf-next 0/3] conntrack: bridge: add double vlan, pppoe and pppoe-in-q Eric Woudstra
2025-09-25 18:30 ` [PATCH v15 nf-next 1/3] netfilter: utils: nf_checksum(_partial) correct data!=networkheader Eric Woudstra
2025-09-25 18:30 ` [PATCH v15 nf-next 2/3] netfilter: bridge: Add conntrack double vlan and pppoe Eric Woudstra
2025-09-26 14:10 ` Simon Horman
2025-10-02 8:11 ` Florian Westphal [this message]
2025-09-25 18:30 ` [PATCH v15 nf-next 3/3] netfilter: nft_chain_filter: Add bridge " Eric Woudstra
2025-10-02 8:25 ` Florian Westphal
2025-10-28 11:43 ` Eric Woudstra
2025-10-30 23:14 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN4zzDvdJKjRxdnt@strlen.de \
--to=fw@strlen.de \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).