From: Dan Carpenter <dan.carpenter@linaro.org>
To: Qingfang Deng <dqfext@gmail.com>
Cc: Andreas Koensgen <ajk@comnets.uni-bremen.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-hams@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+5fd749c74105b0e1b302@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] 6pack: drop redundant locking and refcounting
Date: Tue, 23 Sep 2025 10:11:50 +0300 [thread overview]
Message-ID: <aNJINihPJop9s7IR@stanley.mountain> (raw)
In-Reply-To: <20250923060706.10232-1-dqfext@gmail.com>
On Tue, Sep 23, 2025 at 02:07:06PM +0800, Qingfang Deng wrote:
> The TTY layer already serializes line discipline operations with
> tty->ldisc_sem, so the extra disc_data_lock and refcnt in 6pack
> are unnecessary.
>
> Removing them simplifies the code and also resolves a lockdep warning
> reported by syzbot. The warning did not indicate a real deadlock, since
> the write-side lock was only taken in process context with hardirqs
> disabled.
>
> Reported-by: syzbot+5fd749c74105b0e1b302@syzkaller.appspotmail.com
> Signed-off-by: Qingfang Deng <dqfext@gmail.com>
checkpatch says:
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
Which is relevant here because Google has apparently deleted their
search button and is only displaying the AI button. "The email address
syzbot+5fd749c74105b0e1b302@syzkaller.appspotmail.com is an automated
sender used by ..." Thanks, AI! I can still press enter to do a Google
search but there are no results with syzbot ID.
I can't find a search button on the syzbot website.
Ah. Let's check lore. Hooray! How did we ever survive before lore?
https://lore.kernel.org/all/000000000000e8231f0601095c8e@google.com/
Please add the Closes tag and resend. Otherwise it looks good. Thanks!
This code was copy and pasted from drivers/net/ppp/ppp_synctty.c btw so
that's a similar thing if anyone wants to fix that.
KTODO: remove sp_get/put() from ppp_synctty.c
regards,
dan carpenter
next prev parent reply other threads:[~2025-09-23 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 6:07 [PATCH net-next] 6pack: drop redundant locking and refcounting Qingfang Deng
2025-09-23 7:11 ` Dan Carpenter [this message]
2025-09-23 8:10 ` Qingfang Deng
2025-09-23 8:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNJINihPJop9s7IR@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ajk@comnets.uni-bremen.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+5fd749c74105b0e1b302@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).