From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 300C83218DB for ; Tue, 23 Sep 2025 11:25:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758626744; cv=none; b=cW8ZR2Jp5TCeqDv8E2UqrBZmfcAR5ApcjGmSGVeXEv2YUJqrHQxFZGDCeSOh+8QWWMhChlI11IOdkqUjPLHZROPH3/wBKOaNPWjz1pzxa1dm6TcFdCvb9+ItbpDLYFgGgBXDDL9ErkM70X0cx9MYn6q56SqpSvFMOtGFknkflso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758626744; c=relaxed/simple; bh=nVkEoJfKiwJIMfOR1HpDpbMYukdvZbBD+FIOZ1EqwJY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=QB8cMFmsMhOkFirpbop2aqMfO7dxBM5nqWP1To1DNkEtV88nz+9gUy+YmKuNIXn2iVj5FzWUz3Jb8o3PMe0aV2VPsxNsrF/MsmATGWOTLwKeK/6PIKtf6ZpwKbwmrebBFsfJ+Bp06km9zdeawmQtsaFNL51M9OBar4/8Rqbbqmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=the/cmm+; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="the/cmm+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/AkSn3PmATQkY4KTnXMm8OAmVPwhJx7EQAh2aTkiy+Y=; b=the/cmm+WTt9OfglCw1TUdzqQm lzgqjns1FNeYd+zGmfZnP2zNcV0Hxoipq+Id1EgfjModWgbUufeY+I7SwNOQCDJSCk093Ah2ur5QG NHADZAVfOk/l7/zCRf9uz8MO4834nemcWv3XzKkDzVPgSyHXvsGYAaLp2PgdsYnZX6QCfskCUKJD8 vMjq8mclAQ6mMrw9STPft1j9k/rHBAt2YeelBeLeVLNN+zrEH6XVjAKVj4eQJ+ns/JZA6r30yvuc3 EFpe7Ph/RSyp8+nXq8kJH/xiNNyMjWvasnWpMM+pxwsdPFDepXOXcDMmfccJK3Dv4PIraJ33AwlWu BnV7/rLQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37056) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1v119K-0000000077n-16Sl; Tue, 23 Sep 2025 12:25:34 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1v119G-00000000662-1TA0; Tue, 23 Sep 2025 12:25:30 +0100 Date: Tue, 23 Sep 2025 12:25:30 +0100 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next 0/6] net: stmmac: yet more cleanups Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: Russell King (Oracle) Building on the previous cleanup series, this cleans up yet more stmmac code. - Move stmmac_bus_clks_config() into stmmac_platform() which is where its onlny user is. - Move the xpcs Clause 73 test into stmmac_init_phy(), resulting in simpler code in __stmmac_open(). - Move "can't attach PHY" error message into stmmac_init_phy(). We then start moving stuff out of __stmac_open() into stmmac_open() (and correspondingly __stmmac_release() into stmmac_release()) which is not necessary when re-initialising the interface on e.g. MTU change. - Move initialisation of tx_lpi_timer - Move PHY attachment/detachment - Move PHY error message into stmmac_init_phy() Finally, simplfy the paths in stmmac_init_phy(). drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 - drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 111 ++++++++------------- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 32 ++++++ 3 files changed, 73 insertions(+), 71 deletions(-) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!