Re: [PATCH net-next 01/17] net/ipv6: Introduce payload_len helpers

[Stanislav Fomichev <stfomichev@gmail.com>]

On 09/23, Maxim Mikityanskiy wrote:
> From: Maxim Mikityanskiy <maxim@isovalent.com>
> 
> From: Maxim Mikityanskiy <maxim@isovalent.com>
> 
> The next commits will transition away from using the hop-by-hop
> extension header to encode packet length for BIG TCP. Add wrappers
> around ip6->payload_len that return the actual value if it's non-zero,
> and calculate it from skb->len if payload_len is set to zero (and a
> symmetrical setter).
> 
> The new helpers are used wherever the surrounding code supports the
> hop-by-hop jumbo header for BIG TCP IPv6, or the corresponding IPv4 code
> uses skb_ip_totlen (e.g., in include/net/netfilter/nf_tables_ipv6.h).
> 
> No behavioral change in this commit.
> 
> Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
> ---
>  include/linux/ipv6.h                       | 20 ++++++++++++++++++++
>  include/net/ipv6.h                         |  2 --
>  include/net/netfilter/nf_tables_ipv6.h     |  4 ++--
>  net/bridge/br_netfilter_ipv6.c             |  2 +-
>  net/bridge/netfilter/nf_conntrack_bridge.c |  4 ++--
>  net/ipv6/ip6_input.c                       |  2 +-
>  net/ipv6/ip6_offload.c                     |  7 +++----
>  net/ipv6/output_core.c                     |  7 +------
>  net/netfilter/ipvs/ip_vs_xmit.c            |  2 +-
>  net/netfilter/nf_conntrack_ovs.c           |  2 +-
>  net/netfilter/nf_log_syslog.c              |  2 +-
>  net/sched/sch_cake.c                       |  2 +-
>  12 files changed, 34 insertions(+), 22 deletions(-)
> 
> diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
> index 43b7bb828738..44c4b791eceb 100644
> --- a/include/linux/ipv6.h
> +++ b/include/linux/ipv6.h
> @@ -126,6 +126,26 @@ static inline unsigned int ipv6_transport_len(const struct sk_buff *skb)
>  	       skb_network_header_len(skb);
>  }
>  
> +static inline unsigned int ipv6_payload_len(const struct sk_buff *skb, const struct ipv6hdr *ip6)
> +{
> +	u32 len = ntohs(ip6->payload_len);
> +
> +	return (len || !skb_is_gso(skb) || !skb_is_gso_tcp(skb)) ?
> +	       len : skb->len - skb_network_offset(skb) - sizeof(struct ipv6hdr);

Any reason not to return skb->len - skb_network_offset(skb) - sizeof(struct ipv6hdr)
here unconditionally? Will it not work in some cases?