From: Simon Horman <horms@kernel.org>
To: Tung Quang Nguyen <tung.quang.nguyen@est.tech>
Cc: Dmitry Antipov <dmantipov@yandex.ru>,
Jon Maloy <jmaloy@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"tipc-discussion@lists.sourceforge.net"
<tipc-discussion@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return string length
Date: Fri, 26 Sep 2025 16:41:27 +0100 [thread overview]
Message-ID: <aNa0J14NdhrTus4S@horms.kernel.org> (raw)
In-Reply-To: <GV1P189MB19887FECAF892F25ED014D95C61EA@GV1P189MB1988.EURP189.PROD.OUTLOOK.COM>
On Fri, Sep 26, 2025 at 10:29:31AM +0000, Tung Quang Nguyen wrote:
> >Subject: [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return string
> >length
> >
> >Since the value returned by 'tipc_nodeid2string()' is not used, the function may
> >be adjusted to return the length of the result, which is helpful to drop a few
> >calls to 'strlen()' in 'tipc_link_create()'
> >and 'tipc_link_bc_create()'. Compile tested only.
> >
> >Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> >---
> >v4: revert to v2's behavior and prefer NODE_ID_LEN over
> > explicit constant (Tung Quang Nguyen)
> >v3: convert to check against NODE_ID_LEN (Simon Horman)
> >v2: adjusted to target net-next (Tung Quang Nguyen)
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-26 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 11:26 [PATCH v2 net-next] tipc: adjust tipc_nodeid2string() to return string length Dmitry Antipov
2025-09-25 1:41 ` Tung Quang Nguyen
2025-09-25 12:47 ` Simon Horman
2025-09-25 16:51 ` [PATCH v3 net-next] tipc: adjust tipc_nodeid2string() to check the length of the result Dmitry Antipov
2025-09-26 3:34 ` Tung Quang Nguyen
2025-09-26 7:41 ` [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return string length Dmitry Antipov
2025-09-26 10:29 ` Tung Quang Nguyen
2025-09-26 15:41 ` Simon Horman [this message]
2025-09-30 9:40 ` patchwork-bot+netdevbpf
2025-09-26 15:39 ` [PATCH v3 net-next] tipc: adjust tipc_nodeid2string() to check the length of the result Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNa0J14NdhrTus4S@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dmantipov@yandex.ru \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.quang.nguyen@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).