From: Simon Horman <horms@kernel.org>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftest: net: Fix error message if empty variable
Date: Fri, 26 Sep 2025 14:00:54 +0100 [thread overview]
Message-ID: <aNaOhkKMbZ0Rytex@horms.kernel.org> (raw)
In-Reply-To: <20250925132832.9828-1-alessandro.zanni87@gmail.com>
On Thu, Sep 25, 2025 at 03:28:23PM +0200, Alessandro Zanni wrote:
> Fix to avoid cases where the `res` shell variable is
> empty in script comparisons.
> The comparison has been modified into string comparison to
> handle other possible values the variable could assume.
>
> The issue can be reproduced with the command:
> make kselftest TARGETS=net
>
> It solves the error:
> ./tfo_passive.sh: line 98: [: -eq: unary operator expected
>
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
> ---
>
> Notes:
> v2: edit condition to handle strings
Thanks. This seems more robust to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-26 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 13:28 [PATCH v2] selftest: net: Fix error message if empty variable Alessandro Zanni
2025-09-26 13:00 ` Simon Horman [this message]
2025-09-26 22:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNaOhkKMbZ0Rytex@horms.kernel.org \
--to=horms@kernel.org \
--cc=alessandro.zanni87@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).