From: Simon Horman <horms@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Jon Maloy <jmaloy@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tung Quang Nguyen <tung.quang.nguyen@est.tech>,
tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next] tipc: adjust tipc_nodeid2string() to check the length of the result
Date: Fri, 26 Sep 2025 16:39:59 +0100 [thread overview]
Message-ID: <aNazz8tpiCeFi9KZ@horms.kernel.org> (raw)
In-Reply-To: <20250925165146.457412-1-dmantipov@yandex.ru>
On Thu, Sep 25, 2025 at 07:51:46PM +0300, Dmitry Antipov wrote:
> Since the value returned by 'tipc_nodeid2string()' is not used, the
> function may be adjusted to check the length of the result against
> NODE_ID_LEN, which is helpful to drop a few calls to 'strlen()' and
> simplify 'tipc_link_create()' and 'tipc_link_bc_create()'. Compile
> tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> v3: convert to check against NODE_ID_LEN (Simon Horman)
> v2: adjusted to target net-next (Tung Quang Nguyen)
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-09-26 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 11:26 [PATCH v2 net-next] tipc: adjust tipc_nodeid2string() to return string length Dmitry Antipov
2025-09-25 1:41 ` Tung Quang Nguyen
2025-09-25 12:47 ` Simon Horman
2025-09-25 16:51 ` [PATCH v3 net-next] tipc: adjust tipc_nodeid2string() to check the length of the result Dmitry Antipov
2025-09-26 3:34 ` Tung Quang Nguyen
2025-09-26 7:41 ` [PATCH v4 net-next] tipc: adjust tipc_nodeid2string() to return string length Dmitry Antipov
2025-09-26 10:29 ` Tung Quang Nguyen
2025-09-26 15:41 ` Simon Horman
2025-09-30 9:40 ` patchwork-bot+netdevbpf
2025-09-26 15:39 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNazz8tpiCeFi9KZ@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dmantipov@yandex.ru \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.quang.nguyen@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).