From: Simon Horman <horms@kernel.org>
To: Gopi Krishna Menon <krishnagopi487@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
david.hunter.linux@gmail.com, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH net-next] selftests/net: add tcp_port_share to .gitignore
Date: Tue, 30 Sep 2025 10:02:03 +0100 [thread overview]
Message-ID: <aNuci8Y9ZO9pd0Ua@horms.kernel.org> (raw)
In-Reply-To: <aNucABvb0PvBtCxr@horms.kernel.org>
On Tue, Sep 30, 2025 at 09:59:44AM +0100, Simon Horman wrote:
> On Mon, Sep 29, 2025 at 10:01:38PM +0530, Gopi Krishna Menon wrote:
> > Add the tcp_port_share test binary to .gitignore to avoid
> > accidentally staging the build artifact.
> >
> > Fixes: 8a8241cdaa34 ("selftests/net: Test tcp port reuse after unbinding
> > a socket")
>
> I'm not entirely sure this qualifies for a fixes tag.
> It is user-visible. It's probably annoying.
> But I'm not sure it's a bug.
Also, FTR, fixes tag's shouldn't be line wrapped.
> > Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> > ---
> > tools/testing/selftests/net/.gitignore | 1 +
> > 1 file changed, 1 insertion(+)
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> I notice that tools/testing/selftests/kexec/test_kexec_jump
> is in a similar state. Do you plan to send a patch to address
> that too?
>
> ..
Please note that net-next is now closed.
So if you do respin, please wait for it to re-open once v6.18-rc1 has been
released. About two weeks from now.
next prev parent reply other threads:[~2025-09-30 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 16:31 [PATCH net-next] selftests/net: add tcp_port_share to .gitignore Gopi Krishna Menon
2025-09-30 8:59 ` Simon Horman
2025-09-30 9:02 ` Simon Horman [this message]
2025-09-30 13:47 ` Gopi Krishna Menon
2025-09-30 15:38 ` Jakub Kicinski
2025-09-30 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNuci8Y9ZO9pd0Ua@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=krishnagopi487@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).