* [PATCH net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter()
@ 2025-09-30 12:25 Dan Carpenter
2025-09-30 17:57 ` Tariq Toukan
2025-10-03 18:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-09-30 12:25 UTC (permalink / raw)
To: Yan Burman
Cc: Tariq Toukan, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Amir Vadai, netdev, linux-rdma,
linux-kernel, kernel-janitors
Print "entry->mac" before freeing "entry". The "entry" pointer is
freed with kfree_rcu() so it's unlikely that we would trigger this
in real life, but it's safer to re-order it.
Fixes: cc5387f7346a ("net/mlx4_en: Add unicast MAC filtering")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index d2071aff7b8f..308b4458e0d4 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1180,9 +1180,9 @@ static void mlx4_en_do_uc_filter(struct mlx4_en_priv *priv,
mlx4_unregister_mac(mdev->dev, priv->port, mac);
hlist_del_rcu(&entry->hlist);
- kfree_rcu(entry, rcu);
en_dbg(DRV, priv, "Removed MAC %pM on port:%d\n",
entry->mac, priv->port);
+ kfree_rcu(entry, rcu);
++removed;
}
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter()
2025-09-30 12:25 [PATCH net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter() Dan Carpenter
@ 2025-09-30 17:57 ` Tariq Toukan
2025-10-03 18:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2025-09-30 17:57 UTC (permalink / raw)
To: Dan Carpenter, Yan Burman
Cc: Tariq Toukan, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Amir Vadai, netdev, linux-rdma,
linux-kernel, kernel-janitors
On 30/09/2025 15:25, Dan Carpenter wrote:
> Print "entry->mac" before freeing "entry". The "entry" pointer is
> freed with kfree_rcu() so it's unlikely that we would trigger this
> in real life, but it's safer to re-order it.
>
> Fixes: cc5387f7346a ("net/mlx4_en: Add unicast MAC filtering")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> index d2071aff7b8f..308b4458e0d4 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> @@ -1180,9 +1180,9 @@ static void mlx4_en_do_uc_filter(struct mlx4_en_priv *priv,
> mlx4_unregister_mac(mdev->dev, priv->port, mac);
>
> hlist_del_rcu(&entry->hlist);
> - kfree_rcu(entry, rcu);
> en_dbg(DRV, priv, "Removed MAC %pM on port:%d\n",
> entry->mac, priv->port);
> + kfree_rcu(entry, rcu);
> ++removed;
> }
> }
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks for your patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter()
2025-09-30 12:25 [PATCH net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter() Dan Carpenter
2025-09-30 17:57 ` Tariq Toukan
@ 2025-10-03 18:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-03 18:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: yanb, tariqt, andrew+netdev, davem, edumazet, kuba, pabeni, amirv,
netdev, linux-rdma, linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 30 Sep 2025 15:25:01 +0300 you wrote:
> Print "entry->mac" before freeing "entry". The "entry" pointer is
> freed with kfree_rcu() so it's unlikely that we would trigger this
> in real life, but it's safer to re-order it.
>
> Fixes: cc5387f7346a ("net/mlx4_en: Add unicast MAC filtering")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> [...]
Here is the summary with links:
- [net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter()
https://git.kernel.org/netdev/net/c/4f0d91ba7281
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-03 18:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-30 12:25 [PATCH net] net/mlx4: prevent potential use after free in mlx4_en_do_uc_filter() Dan Carpenter
2025-09-30 17:57 ` Tariq Toukan
2025-10-03 18:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).