From: Simon Horman <horms@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
Philippe Guibert <philippe.guibert@6wind.com>
Subject: Re: [PATCH net] doc: fix seg6_flowlabel path
Date: Sat, 11 Oct 2025 09:02:00 +0100 [thread overview]
Message-ID: <aOoO-AXbtSEwEoZH@horms.kernel.org> (raw)
In-Reply-To: <20251010141859.3743353-1-nicolas.dichtel@6wind.com>
On Fri, Oct 10, 2025 at 04:18:59PM +0200, Nicolas Dichtel wrote:
> This sysctl is not per interface; it's global per netns.
>
> Fixes: 292ecd9f5a94 ("doc: move seg6_flowlabel to seg6-sysctl.rst")
> Reported-by: Philippe Guibert <philippe.guibert@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Thanks.
Thinking aloud:
I see that above the lines added by this patch are documentation
for the variables seg6_require_hmac and seg6_enabled. Which
are per interface. And thus documented correctly.
And below the lines added by the patch is only seg6_flowlabel.
Which, as the patch description says, are global rather than
per interface. And with this patch that is now documented correctly too.
I also agree that this problem was introduced by the cited commit.
And as a documentation correction it seems appropriate for net.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-11 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 14:18 [PATCH net] doc: fix seg6_flowlabel path Nicolas Dichtel
2025-10-11 8:02 ` Simon Horman [this message]
2025-10-12 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOoO-AXbtSEwEoZH@horms.kernel.org \
--to=horms@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=philippe.guibert@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).