From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C86242DF141; Thu, 16 Oct 2025 13:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760622742; cv=none; b=r0DFwYrCPn9XZ60FzhNC+HHakHV1KjcVkN5aAriiVGH5R2BU2mUmK0M4SonFN+U4wC5+75YSDHXjvQouDHP1oAfSLVLXHgSFMTYefYfNMzQ46l5fln2AsXGB/ZenAUEOObhBZCR/ngfuTdnXSCvBRiWYcOpbTOMD0abr4oDWLz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760622742; c=relaxed/simple; bh=ULeaJJUMe/wC90ReLYUVCqTHShIiS1YZvkS1YfAkp5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fl5rsVGGz4GXijoowVxjxUFNxl7MyOg9GVASRKXOgxr9aPnJa+aCI9lJej+9BUANUPZ6bwWAWyhKiUhEdzz0zTZOGjTLGlcPmTsrSxm3reAJXnI/2502pYIb7E3XJZMtxSgcSt5ALh8kh2lICCR8SEsMamUSXIi9zAv/mDMnqAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=0+dTZXBd; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="0+dTZXBd" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UmCdG/YPwALyDLpBb5siWg/i3BOrWdjDOVrZPQUGrZ8=; b=0+dTZXBd5lApnHs2iQaBbz/W/V Q7bJFJnGIA2uG8tjS5UsEsS5Zf8UZNrrq2xOtoMqAw1ePzjfdRuqYhMDAbHp9IA6SKikFFdvxfcwL dzr4TP20v7Ikpb4eFepO6AgDnISJvNmQnXw09aUuufpFMWhnQxXRnGKqTiGPvjrCQbdma4YuvvwtH YVPgtZbE5K1ZsOHDzJG50RAIpAUra2yfNcA0krjXV1cBF/ch9+Buy3F6o2btiNcTXkFL0ICrSNJZY pxEOMeHRoS1NJFq8P6hRm8ihzKlijAE+794qKuQIu2Wqr0T2GPcn5xYNKe/fQcEoCLoRgAVrs5uRJ eOda1ZYw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38764) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1v9OON-000000006M1-0eca; Thu, 16 Oct 2025 14:51:43 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1v9OO9-000000003K9-3HzO; Thu, 16 Oct 2025 14:51:29 +0100 Date: Thu, 16 Oct 2025 14:51:29 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Heiner Kallweit , Abhishek Chauhan , Alexandre Torgue , Alexis Lothore , Andrew Lunn , Boon Khai Ng , Choong Yong Liang , Daniel Machon , "David S. Miller" , Drew Fustini , Emil Renner Berthing , Eric Dumazet , Faizal Rahim , Furong Xu <0x1207@gmail.com>, Inochi Amaoto , Jacob Keller , Jakub Kicinski , "Jan Petrous (OSS)" , Jisheng Zhang , Kees Cook , Kunihiko Hayashi , Lad Prabhakar , Ley Foon Tan , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Matthew Gerlach , Maxime Chevallier , Maxime Coquelin , Michal Swiatkowski , netdev@vger.kernel.org, Oleksij Rempel , Paolo Abeni , Rohan G Thomas , Shenwei Wang , Simon Horman , Song Yoong Siang , Swathi K S , Tiezhu Yang , Vinod Koul , Vladimir Oltean , Vladimir Oltean , Yu-Chun Lin Subject: Re: [PATCH net-next 11/14] net: stmmac: do not require snps,ps-speed for SGMII Message-ID: References: <15ea57e0-d127-4722-b752-4989d5a443c0@lunn.ch> <6545b453-e99e-4f44-a206-ef14deb7f96a@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6545b453-e99e-4f44-a206-ef14deb7f96a@lunn.ch> Sender: Russell King (Oracle) On Thu, Oct 16, 2025 at 03:03:34PM +0200, Andrew Lunn wrote: > > I don't at present, and I'm not sure what the point of updating it > > would actually be, because this is another thing that's just broken. > > > Hence, I would like this property a slow and painful^h^h^hfree death. > > Maybe mark the property deprecated, and remove all explanation of it > > apart from stating that it's obsolete after this patch series has > > been merged and we've proven that it's never been useful. > > And this is what i was thinking. At least mark it deprecated. If you > want to remove the documentation late, i'm fine with that as well. It's rather premature to do this - this series doesn't change anything in the way that snps,ps-speed behaves. Setting this still: 1. sets the SGMII rate adapter to take its speed configuration from the MAC control register rather than the in-band config. 2. enables the exchange of the SGMII in-band config. What it doesn't do, and has never done, is to ensure that the in-band config that is sent contains the speed and duplex information for the SGMII link partner due to a repeated typo in the individual core sub- drivers. I'm not intending removing this until we have a different way to specify it, e.g. PHY_INTERFACE_MODE_REVSGMII, but that is currently looking unlikely. However, with PHY_INTERFACE_MODE_REVSGMII, we would need to make the change (fix the typo bug) to publish the correct in-band config. I think a bit more thought is needed before going down that path, because if we're publishing the config, is it a fixed-link. That's something that we need to sort out in the PHY_INTERFACE_MODE_REVSGMII discussions... if we're still going with it. So, right now what happens here entirely depends on stuff we have yet to make decisions on, and so marking it deprecated now is too early. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!