From: Simon Horman <horms@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: Kconfig: discourage drop_monitor enablement
Date: Thu, 16 Oct 2025 17:58:40 +0100 [thread overview]
Message-ID: <aPEkQA6cF2-STgv2@horms.kernel.org> (raw)
In-Reply-To: <20251016115147.18503-1-fw@strlen.de>
On Thu, Oct 16, 2025 at 01:51:47PM +0200, Florian Westphal wrote:
> Quoting Eric Dumazet:
> "I do not understand the fascination with net/core/drop_monitor.c [..]
> misses all the features, flexibility, scalability that 'perf',
> eBPF tracing, bpftrace, .... have today."
>
> Reword DROP_MONITOR kconfig help text to clearly state that its not
> related to perf-based drop monitoring and that its safe to disable
> this unless support for the older netlink-based tools is needed.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
I think it is always good to guide people in the right direction.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-16 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 11:51 [PATCH net-next] net: Kconfig: discourage drop_monitor enablement Florian Westphal
2025-10-16 16:58 ` Simon Horman [this message]
2025-10-16 18:01 ` Eric Dumazet
2025-10-17 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPEkQA6cF2-STgv2@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).