From: Hangbin Liu <liuhangbin@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sabrina Dubroca <sdubroca@redhat.com>,
Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Stanislav Fomichev <stfomichev@gmail.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
bridge@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: Re: [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices
Date: Fri, 17 Oct 2025 02:53:59 +0000 [thread overview]
Message-ID: <aPGvxybFp42UN_f5@fedora> (raw)
In-Reply-To: <fw4pvt7morcydktpqmmotab7pyvbixhrszgdfpl4dut52rfesf@4fztqcywdwpm>
On Thu, Oct 16, 2025 at 03:24:59PM +0200, Jiri Pirko wrote:
> Thu, Oct 16, 2025 at 02:38:15PM +0200, liuhangbin@gmail.com wrote:
> >On Thu, Oct 16, 2025 at 01:27:00PM +0200, Jiri Pirko wrote:
> >> >> How about "master_upper"? This is already widely used to refer to
> >> >> bond/team/bridge/other master soft devices.
> >> >>
> >> >> MASTER_UPPER_DEV_VLAN_FEATURES?
> >> >
> >> >I'm not sure if we should avoid using "master" now. Maybe just UPPER_DEV_VLAN_FEATURES?
> >>
> >> Why? We have "master_upper" to point exactly at this kind of device.
> >
> >I mean try not use "master/slave" words. I'm OK to use UPPER_DEV_* prefix.
>
> If you don't want to use that, change the existing code. But when the
> existing code uses that, new code should be consistent with it.
OK, I will update the name.
Thanks
Hangbin
next prev parent reply other threads:[~2025-10-17 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 8:02 [PATCHv4 net-next 0/4] net: common feature compute for upper interface Hangbin Liu
2025-10-14 8:02 ` [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices Hangbin Liu
2025-10-14 9:40 ` Jiri Pirko
2025-10-15 1:25 ` Hangbin Liu
2025-10-16 11:27 ` Jiri Pirko
2025-10-16 12:38 ` Hangbin Liu
2025-10-16 13:24 ` Jiri Pirko
2025-10-17 2:53 ` Hangbin Liu [this message]
2025-10-14 14:02 ` Simon Horman
2025-10-15 3:03 ` Hangbin Liu
2025-10-14 8:02 ` [PATCHv4 net-next 2/4] bonding: use common function to compute the features Hangbin Liu
2025-10-14 8:02 ` [PATCHv4 net-next 3/4] team: " Hangbin Liu
2025-10-14 8:02 ` [PATCHv4 net-next 4/4] net: bridge: " Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPGvxybFp42UN_f5@fedora \
--to=liuhangbin@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sdubroca@redhat.com \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox