From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE942EBB88 for ; Mon, 20 Oct 2025 09:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760951872; cv=none; b=q5xypGOSEHaMmdxI6ujvRxRh2KtbfHIAsoZz61ltXdlF7xBdSh8v2e+I3UQ2VhWRC1EsK1PAPCD8iyh179QXoaYfeww4Di97IcD5Ux9zjwitT+KUUtc6SNR3MJjygBfD/QdoMGEWZXJHFpPuyuq4HfBSbvX7f/drFmmFfgfNMVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760951872; c=relaxed/simple; bh=IcOzGfRCiD84omBUBER3702x/g94WvAaK4yDyl2lh9g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LpV/G2vgm8Qnk+dqQIdY9UOPN805Y/IUeJq85FomprppCD1/rsw74lK5VGuBrKRmqp3NENVt409Rhi0yPdbsNJsWv2VVFi+tKbUME0fvf9A4UdG7+Gqc1DJiPRgC7jdA/yI/c8pGsJ/9/ffuOGaFDQdwZzNe9kmwoWLAvvXv1S8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=KRY2lsgS; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=VOe0ig4b; arc=none smtp.client-ip=202.12.124.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="KRY2lsgS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="VOe0ig4b" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id D120C1D0002A; Mon, 20 Oct 2025 05:17:49 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Mon, 20 Oct 2025 05:17:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1760951869; x= 1761038269; bh=AIfRkYJxkIS5P5kdA6Sl13c3qk4tod36pCxOV9tgd84=; b=K RY2lsgSKLgfvDXeFixPglzBA+iSdEs97NWrIEhPZ0K1w7eIkSlrfd2kGCo945pqT 55jNvHv6X7ne1IkcXo2+ZM9IIeP92GJezbHDa9dXhm9jZYyJGR6uor1+mVhwh4Db SBCEQXqtSWWXz8+v9Px1hU1su4DNeKXu4MoLKBoUXzHMaUye48A+AxrPgT9dbcP/ n7GIbdUPeMoYQ3mdcEausA5Pw5GX9JJIEr0j1ziXBR8JEfe4xQGU+b4ECBz3TzR8 jfRGZHSPa2F7F1uwI6hOGmIhf2SOBjfmOz4ETnzXaKj2VhEUmurTLK9pU62eyRv+ aCbkY3R6tGuMfH31eEPQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1760951869; x=1761038269; bh=AIfRkYJxkIS5P5kdA6Sl13c3qk4tod36pCx OV9tgd84=; b=VOe0ig4bLozaNZCZa6mfA+f9ryn3VXjo74zcWbGvKW147JjwUUa VU8rCr6oAbNTkb6WO0IGQl3KAxcfizIYVHAOTwb8/oz5XTRiEs674K0B4RxCVikh UnHtkyJxE4l5ZO2agKLye3UbQt03r6eSD3RWsNeY5JQoR9oSdkkg3AZFNsTrXoGY KFrZ2VzqM2AHIIy60GYFLToiPnYaYTPrm3mhLpbrLT+ESOQPfFTOE4cRIaQGjA3g Q5Z8kVOcJu4qaPuhj8AnVMk2wizjywyiaqX2yLpE8m7agoYPXmknCCfBqRPTifkr Y5EUVQ88rBMewP6Sw2jdgw90fK/F010x+3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddufeejgeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedujedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhiuhhhrghnghgsihhnsehgmhgrihhlrd gtohhmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtohepjhhvsehjvhhoshgsuhhrghhhrdhnvghtpdhrtghpthhtoheprghnughrvg ifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghm lhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomh dprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrsggv nhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehjihhrihesrhgvshhnuhhllhhird hush X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Oct 2025 05:17:48 -0400 (EDT) Date: Mon, 20 Oct 2025 11:17:47 +0200 From: Sabrina Dubroca To: Hangbin Liu Cc: netdev@vger.kernel.org, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Simon Horman , Ido Schimmel , Shuah Khan , Stanislav Fomichev , Stanislav Fomichev , Kuniyuki Iwashima , Alexander Lobakin , bridge@lists.linux.dev Subject: Re: [PATCHv6 net-next 4/4] net: bridge: use common function to compute the features Message-ID: References: <20251017034155.61990-1-liuhangbin@gmail.com> <20251017034155.61990-5-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251017034155.61990-5-liuhangbin@gmail.com> 2025-10-17, 03:41:55 +0000, Hangbin Liu wrote: > Previously, bridge ignored all features propagation and DST retention, > only handling explicitly the GSO limits. > > By switching to the new helper netdev_compute_master_upper_features(), the bridge > now expose additional features, depending on the lowers capabilities. > > Since br_set_gso_limits() is already covered by the helper, it can be > removed safely. > > Bridge has it's own way to update needed_headroom. So we don't need to > update it in the helper. > > Signed-off-by: Hangbin Liu > --- > net/bridge/br_if.c | 22 +++------------------- > 1 file changed, 3 insertions(+), 19 deletions(-) Reviewed-by: Sabrina Dubroca -- Sabrina