From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A07882ECE9D for ; Mon, 20 Oct 2025 09:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760951455; cv=none; b=JAMJSZCdAwhtXTWQguUnn5ng54hkfj0kmNYiV8mtoIj2BYsssWT1mXT50ggzvOAcRer0irwBkNDYsvZqGLSDmsZkf07QNJOmz63ete0gTdPxWbSqIvGhXIrEt35CUS/QCBepzkUiaW4JWjW5+qUnz2DrfeOQYj3bZnqbQ4bSAGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760951455; c=relaxed/simple; bh=oYtTqecCnNQx2Ik8xx5C830t05U2Un7+CpAD1L9SKZk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mG+mJrZCneifA3fiDmILRfBPXcb4Xl+YHkRcheo9e6DvyQlxcmteLpUX/v03mrNfR8tYwUAT8mdm0KTucenvJIiWFpKjXq6rh9ZX/cWEsTya2YWUB30u1qB3NuR8eYeBLRXQYLuLTAbRZJklNQM+pah24cGZwgaZvhdeFi/exIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=0jU3TVqq; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=NXwIPP9v; arc=none smtp.client-ip=202.12.124.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="0jU3TVqq"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="NXwIPP9v" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 483751D000C3; Mon, 20 Oct 2025 05:10:51 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Mon, 20 Oct 2025 05:10:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1760951451; x= 1761037851; bh=wGI4UPOkusN6cayT7+rVnJToFhsPbfwHu5GfFivImJQ=; b=0 jU3TVqqtXu8AFffzzU1t+1+ZK+VXVpnRKRu6j9EXLxiI3L44grhgqSgNN3Q+HS4A jsKdQ336JNPE9J9wmDaPWH+X7G38ctZt4fVBhuL3QhIDa6dhBn1HcjeYkyomcnAH 1dW+HWP0/Bbqv8Ug0JS4S1YrfSfneFqwwBJE+QxWpsF/fdaDFz5ezTCJVWtD0CbQ JXYNZe3EI4akCaSaxrQHMtQkzmWshMri6A4N1Hbv21DTBsuh/6Z9ZsOLviC3u9VA pcDOXRxIQdR8byrnhfhwE8UVNfXb6wjxk9q71akOMrdYmmhq3D+ZEQtxMaBAQi7u TZRaLfYMi76s0bQtIUiNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1760951451; x=1761037851; bh=wGI4UPOkusN6cayT7+rVnJToFhsPbfwHu5G fFivImJQ=; b=NXwIPP9vGPf7q9bWfkpJa0fDydEvcdTf6T52RPSL0hQrDtJPZ76 Hud7YF00GO5W2Nz6Z1ScJDQet8JJ8+4skPtc8bzVpl1ZIwOml9+JnRtj3Si7mNYZ vFq/fwqsfKJmp50GeF12FJl+CLIwZK/qa7spZuMSXXqqsHkXX1+dNN1+0ZJsHqD6 KBqw1b4Za0Ow8nIut6WNcar6LDDTmiflkHiYniJE62F5YGurcjSLF7POj7jzZFYi SxQPMQrk6rPNXxOvNgnyx0rnVmvbkaqzXzZFoRlA6rD+zsGo7I6s2bkSRkK0l5+C OiPuiKGFvWq9Xcu2FH97DWVqq2ZdHeaEMaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddufeejgedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedujedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhiuhhhrghnghgsihhnsehgmhgrihhlrd gtohhmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtohepjhhvsehjvhhoshgsuhhrghhhrdhnvghtpdhrtghpthhtoheprghnughrvg ifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghm lhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomh dprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrsggv nhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehjihhrihesrhgvshhnuhhllhhird hush X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Oct 2025 05:10:50 -0400 (EDT) Date: Mon, 20 Oct 2025 11:10:48 +0200 From: Sabrina Dubroca To: Hangbin Liu Cc: netdev@vger.kernel.org, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Simon Horman , Ido Schimmel , Shuah Khan , Stanislav Fomichev , Stanislav Fomichev , Kuniyuki Iwashima , Alexander Lobakin , bridge@lists.linux.dev Subject: Re: [PATCHv6 net-next 2/4] bonding: use common function to compute the features Message-ID: References: <20251017034155.61990-1-liuhangbin@gmail.com> <20251017034155.61990-3-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251017034155.61990-3-liuhangbin@gmail.com> 2025-10-17, 03:41:53 +0000, Hangbin Liu wrote: > Use the new functon netdev_compute_master_upper_features() to compute the bonding > features. > > Note that bond_compute_features() currently uses bond_for_each_slave() > to traverse the lower devices list, and that is just a macro wrapper of > netdev_for_each_lower_private(). We use similar helper > netdev_for_each_lower_dev() in netdev_compute_master_upper_features() to > iterate the slave device, as there is not need to get the private data. > > No functional change intended. > > Signed-off-by: Hangbin Liu > --- > drivers/net/bonding/bond_main.c | 99 ++------------------------------- > 1 file changed, 4 insertions(+), 95 deletions(-) Reviewed-by: Sabrina Dubroca -- Sabrina