From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D3D02ECEA3 for ; Mon, 20 Oct 2025 09:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.156 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760951498; cv=none; b=Zffh6YsZaJOtZomjFuEAmo3qmqhrKHMhvOncgn7MBz/qWisFnAq6dR108vfthxWji06wzVu23cN9EaIHjHpBriY6d4hf7hZRIihzhU4UdHwkwTkVMy4Fkin0TM2tYMmDEHplRXSGiuWRLV/qGTynEjZrY3WEmC67biFhMbcwBeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760951498; c=relaxed/simple; bh=r05lQ8QjsXHO/YtNy9p9A+fhssnqL2q9NxJ9w9nL3bs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UzaHFj7ze18/MaGI9wwGQBdmzm2Z+P5eUBzOJw3sxGVYDe2P3vPp7kVvOKjK30L9wdi7P4w2PDTa3dVzMHrCVjliEkufuLjsYQgPsVY8mzPFmhZrRjr7FO/Yr588Ge2wazNal6mI+tyYnE7A9M/mfs11rsOPKsEsuOrH/1eDOcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=X2goDTtl; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=eJNNtYcQ; arc=none smtp.client-ip=202.12.124.156 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="X2goDTtl"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="eJNNtYcQ" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id E01D37A0027; Mon, 20 Oct 2025 05:11:34 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Mon, 20 Oct 2025 05:11:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1760951494; x= 1761037894; bh=4Nwekh16SpF5rye+o1P7aLYihsMbKaZuUyC1glA+aIc=; b=X 2goDTtlkt4Few3Y3IMUjM89Pxr5DBsYKE5ECEJHBq3Af6x9IoEDficsG8guXDj5d Z+fgSpnYZEwGlYxJkQbWMltkYrjUhTBZikQaPSxsITssdKHsVkjVXpCiIr15FCMd xEzh3cEC7X2i9I7AxFNovXXYsjKfci2UF/babh0yY0NrcQs1KgbXL+Xk4qSrcnz9 WsDp76Xr8afaAYpRJCZofOWmiie2sP0LwH0Oo3tOXmk0YLWdhDdTIqIXJ0F6SnzJ qKCrEJrvCk2tfvJD00K1U7oUeq+7d+7WRDQY1oJpGYsnAwbrhGSIHT5anXLCBnxj l0BO3yDWKYeuTRuUegDUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1760951494; x=1761037894; bh=4Nwekh16SpF5rye+o1P7aLYihsMbKaZuUyC 1glA+aIc=; b=eJNNtYcQSObbwrQdP+dp0gcGhSUG9mzPuLGuXDTXs/Ckr4KloiT N+OjEr9CSMy2w+z2IJhuXC5pOkTp3NwG3L3vtEY0/Dvz9UUIptxbp3zECmZJIzXK IK3XZZTjstU8rGlXAib+fI3PWfusrqH4BQLzr5IV2ukhs1RLeFe+HmImalipS54G XtbF9tZNxZWSNfosoMCu1Grhu/Z3UJqsez1fuG6LnSA1DnRobhqPyl8d62CY8l/U Q34b7gNghA6oddboYg0RJ5YYgMYiVXvZTpBOkLQ00sUR4nq9j0m3vTO1ysHUU2nz lr3UANfTtIvhdfGixwinnPr1HZIFR/gu39Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddufeejgeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedujedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhiuhhhrghnghgsihhnsehgmhgrihhlrd gtohhmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtohepjhhvsehjvhhoshgsuhhrghhhrdhnvghtpdhrtghpthhtoheprghnughrvg ifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghm lhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomh dprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrsggv nhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehjihhrihesrhgvshhnuhhllhhird hush X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Oct 2025 05:11:33 -0400 (EDT) Date: Mon, 20 Oct 2025 11:11:32 +0200 From: Sabrina Dubroca To: Hangbin Liu Cc: netdev@vger.kernel.org, Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Simon Horman , Ido Schimmel , Shuah Khan , Stanislav Fomichev , Stanislav Fomichev , Kuniyuki Iwashima , Alexander Lobakin , bridge@lists.linux.dev Subject: Re: [PATCHv6 net-next 3/4] team: use common function to compute the features Message-ID: References: <20251017034155.61990-1-liuhangbin@gmail.com> <20251017034155.61990-4-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251017034155.61990-4-liuhangbin@gmail.com> 2025-10-17, 03:41:54 +0000, Hangbin Liu wrote: > Use the new helper netdev_compute_master_upper_features() to compute the > team device features. This helper performs both the feature computation > and the netdev_change_features() call. > > Note that such change replace the lower layer traversing currently done > using team->port_list with netdev_for_each_lower_dev(). Such change is > safe as `port_list` contains exactly the same elements as > `team->dev->adj_list.lower` and the helper is always invoked under the > RTNL lock. > > With this change, the explicit netdev_change_features() in team_add_slave() > can be safely removed, as team_port_add() already takes care of the > notification via netdev_compute_master_upper_features(), and same thing for > team_del_slave() > > This also fixes missing computations for MPLS, XFRM, and TSO/GSO partial > features. > > Signed-off-by: Hangbin Liu > --- > drivers/net/team/team_core.c | 83 +++--------------------------------- > 1 file changed, 6 insertions(+), 77 deletions(-) Reviewed-by: Sabrina Dubroca -- Sabrina