From: Sabrina Dubroca <sd@queasysnail.net>
To: Ralf Lici <ralf@mandelbit.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Mina Almasry <almasrymina@google.com>,
Eric Biggers <ebiggers@google.com>,
Antonio Quartulli <antonio@openvpn.net>
Subject: Re: [PATCH net v2 1/3] net: datagram: introduce datagram_poll_queue for custom receive queues
Date: Mon, 20 Oct 2025 12:17:31 +0200 [thread overview]
Message-ID: <aPYMOwuD_PO7Nim_@krikkit> (raw)
In-Reply-To: <20251020073731.76589-2-ralf@mandelbit.com>
LGTM, just a small nit:
2025-10-20, 09:37:29 +0200, Ralf Lici wrote:
> +/**
> + * datagram_poll - generic datagram poll
> + * @file: file struct
> + * @sock: socket
> + * @wait: poll table
> + *
> + * Datagram poll: Again totally generic. This also handles
> + * sequenced packet sockets providing the socket receive queue
> + * is only ever holding data ready to receive.
> + *
> + * Note: when you *don't* use this routine for this protocol,
> + * and you use a different write policy from sock_writeable()
> + * then please supply your own write_space callback.
Maybe you could document the return value here as well, since you're
touching this code.
> + */
> +__poll_t datagram_poll(struct file *file, struct socket *sock, poll_table *wait)
--
Sabrina
next prev parent reply other threads:[~2025-10-20 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 7:37 [PATCH net v2 0/3] fix poll behaviour for TCP-based tunnel protocols Ralf Lici
2025-10-20 7:37 ` [PATCH net v2 1/3] net: datagram: introduce datagram_poll_queue for custom receive queues Ralf Lici
2025-10-20 10:17 ` Sabrina Dubroca [this message]
2025-10-20 12:22 ` Ralf Lici
2025-10-20 7:37 ` [PATCH net v2 2/3] espintcp: use datagram_poll_queue for socket readiness Ralf Lici
2025-10-20 7:37 ` [PATCH net v2 3/3] ovpn: use datagram_poll_queue for socket readiness in TCP Ralf Lici
2025-10-20 10:17 ` Sabrina Dubroca
2025-10-20 12:22 ` Ralf Lici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPYMOwuD_PO7Nim_@krikkit \
--to=sd@queasysnail.net \
--cc=almasrymina@google.com \
--cc=antonio@openvpn.net \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@mandelbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).