[RFC] net: macb: enable IPv6 support for TSO

[RFC] net: macb: enable IPv6 support for TSO

[zuoqian]

New Cadence GEM hardware support TSO for both ipv4 and IPv6 protocols,
but the driver currently lacks the NETIF_F_TSO6 feature flag for IPv6 TSO.

Signed-off-by: zuoqian <zuoqian113@gmail.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 214f543af3b8..a154c9f3c325 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -78,7 +78,7 @@ struct sifive_fu540_macb_mgmt {
 #define GEM_MAX_TX_LEN		(unsigned int)(0x3FC0)
 
 #define GEM_MTU_MIN_SIZE	ETH_MIN_MTU
-#define MACB_NETIF_LSO		NETIF_F_TSO
+#define MACB_NETIF_LSO		(NETIF_F_TSO | NETIF_F_TSO6)
 
 #define MACB_WOL_ENABLED		BIT(0)
 
-- 
2.49.0

Re: [RFC] net: macb: enable IPv6 support for TSO

[Andrew Lunn]

On Mon, Oct 20, 2025 at 09:55:08AM +0000, zuoqian wrote:
> New Cadence GEM hardware support TSO for both ipv4 and IPv6 protocols,

What about the 'Old' Cadence GEM hardware? I'm assuming you mean
something by New here. So it would be good to make a comment something
like that IPv4 and IPv6 TSO was added at the same time. So if IPv4 TSO
is supported, IPv6 TSO should also be supported, so there is no danger
of regressions with older GEM hardware.

> Signed-off-by: zuoqian <zuoqian113@gmail.com>

This means you are agreeing to:

https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

However, we say "using a known identity", since this is a legal
statement. I don't think zuoqian qualifies. Please you a full name
here.

    Andrew

---
pw-bot: cr

Re: [RFC] net: macb: enable IPv6 support for TSO

[Zuoqian]

On Mon, Oct 20, 2025 at 09:01:13PM +0200, Andrew Lunn wrote:
> On Mon, Oct 20, 2025 at 09:55:08AM +0000, zuoqian wrote:
> > New Cadence GEM hardware support TSO for both ipv4 and IPv6 protocols,
> 
> What about the 'Old' Cadence GEM hardware? I'm assuming you mean
> something by New here. So it would be good to make a comment something
> like that IPv4 and IPv6 TSO was added at the same time. So if IPv4 TSO
> is supported, IPv6 TSO should also be supported, so there is no danger
> of regressions with older GEM hardware.
>
Thank you for your suggestion. 
The Cadence GEM hardware I'm using supports both IPv4 and IPv6 TSO.
However, I'm uncertain whether the driver's initial support only for
IPv4 TSO implies that older hardware versions exist which solely support
IPv4 TSO.
> > Signed-off-by: zuoqian <zuoqian113@gmail.com>
> 
> This means you are agreeing to:
> 
> https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
> 
> However, we say "using a known identity", since this is a legal
> statement. I don't think zuoqian qualifies. Please you a full name
> here.
> 
>     Andrew
> 
> ---
> pw-bot: cr
Regarding the identity verification, "zuoqian" is indeed my legal full
name.

Regards,
Zuoqian