netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Tonghao Zhang <tonghao@bamaicloud.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCH net-next] net: bonding: use workqueue to make sure peer notify updated
Date: Tue, 21 Oct 2025 12:21:38 +0100	[thread overview]
Message-ID: <aPdswnBumIsSq8fY@horms.kernel.org> (raw)
In-Reply-To: <20251021052249.47250-1-tonghao@bamaicloud.com>

On Tue, Oct 21, 2025 at 01:22:49PM +0800, Tonghao Zhang wrote:
> The RTNL might be locked, preventing ad_cond_set_peer_notif from acquiring
> the lock and updating send_peer_notif. This patch addresses the issue by
> using a workqueue. Since updating send_peer_notif does not require high
> real-time performance, such delayed updates are entirely acceptable.
> 
> Cc: Jay Vosburgh <jv@jvosburgh.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Simon Horman <horms@kernel.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Cc: Nikolay Aleksandrov <razor@blackwall.org>
> Cc: Hangbin Liu <liuhangbin@gmail.com>
> Suggested-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Tonghao Zhang <tonghao@bamaicloud.com>
> ---
>  drivers/net/bonding/bond_3ad.c  |  7 ++-----
>  drivers/net/bonding/bond_main.c | 27 +++++++++++++++++++++++++++
>  include/net/bonding.h           |  2 ++
>  3 files changed, 31 insertions(+), 5 deletions(-)

This is not a proper review. So please wait, say a day, for one.

But this patch does not apply cleanly to net-next,
and thus will need to be rebased and reposted.

-- 
pw-bot: cr

  reply	other threads:[~2025-10-21 11:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21  5:22 [PATCH net-next] net: bonding: use workqueue to make sure peer notify updated Tonghao Zhang
2025-10-21 11:21 ` Simon Horman [this message]
2025-10-22  2:02 ` Jay Vosburgh
2025-10-26  9:59   ` Tonghao Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPdswnBumIsSq8fY@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=tonghao@bamaicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).