From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/7] net: dsa: lantiq_gswip: clarify GSWIP 2.2 VLAN mode in comment
Date: Wed, 22 Oct 2025 08:43:33 +0100 [thread overview]
Message-ID: <aPiLJXZu_BaZrYX6@pidgin.makrotopia.org> (raw)
In-Reply-To: <9d0a589a-23f5-45a9-b3ab-1db10eb56af3@lunn.ch>
Hi Andrew,
On Wed, Oct 22, 2025 at 04:29:26AM +0200, Andrew Lunn wrote:
> On Sun, Oct 19, 2025 at 01:46:54PM +0100, Daniel Golle wrote:
> 61;8003;1c> The comment above writing the default PVID incorrectly states that
> > "GSWIP 2.2 (GRX300) and later program here the VID directly."
> > The truth is that even GSWIP 2.2 and newer maintain the behavior of
> > GSWIP 2.1 unless the VLANMD bit in PCE Global Control Register 1 is
> > set ("GSWIP2.2 VLAN Mode").
> > Fix the misleading comment accordingly.
> >
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thank you for reviewing, however, you've replied to the surperseded v3
submission while v5 is current. The patches for which you sent a
Reviewed-by:-tag have not changed since v3, except for 2/7 which is now
using the `REGMAP_UPSHIFT(2)` macro instead of `-2` as a plain number.
Would you mind sending the Reviewed-by:-tags again in reply to the v5[1]
patches?
Cheers
Daniel
[1]: https://patchwork.kernel.org/project/netdevbpf/list/?series=1013992
next prev parent reply other threads:[~2025-10-22 7:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 12:46 [PATCH net-next v3 0/7] net: dsa: lantiq_gswip: use regmap for register access Daniel Golle
2025-10-19 12:46 ` [PATCH net-next v3 1/7] net: dsa: lantiq_gswip: clarify GSWIP 2.2 VLAN mode in comment Daniel Golle
2025-10-22 2:29 ` Andrew Lunn
2025-10-22 7:43 ` Daniel Golle [this message]
2025-10-19 12:47 ` [PATCH net-next v3 2/7] net: dsa: lantiq_gswip: convert accessors to use regmap Daniel Golle
2025-10-22 2:34 ` Andrew Lunn
2025-10-19 12:48 ` [PATCH net-next v3 3/7] net: dsa: lantiq_gswip: convert trivial accessor uses to regmap Daniel Golle
2025-10-22 2:35 ` Andrew Lunn
2025-10-19 12:48 ` [PATCH net-next v3 4/7] net: dsa: lantiq_gswip: manually convert remaining uses of read accessors Daniel Golle
2025-10-19 22:25 ` Jakub Kicinski
2025-10-20 0:23 ` Daniel Golle
2025-10-19 12:48 ` [PATCH net-next v3 5/7] net: dsa: lantiq_gswip: replace *_mask() functions with regmap API Daniel Golle
2025-10-22 2:36 ` Andrew Lunn
2025-10-19 12:48 ` [PATCH net-next v3 6/7] net: dsa: lantiq_gswip: optimize regmap_write_bits() statements Daniel Golle
2025-10-19 12:48 ` [PATCH net-next v3 7/7] net: dsa: lantiq_gswip: harmonize gswip_mii_mask_*() parameters Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPiLJXZu_BaZrYX6@pidgin.makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).