From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685B42D592B for ; Wed, 22 Oct 2025 14:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142403; cv=none; b=WMOVHiNVhyaVlW1KLkW4EyKUvVN52AovHyA83feQxKYTvvfzb2G6XLlsMnwvcSJe13DVdivUDz+krnL0LNruoDOLGgyPUrCI3EUUcWI0Ozcw2TeKdTEHnY22E269c7isNoJ1qCXOxMqOQAZWD3I1BiKm8n8wkc/9U8YoKIWEqj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142403; c=relaxed/simple; bh=NTjr/aDa1hLeFGlH9Fg8NPt4B3bPRxxJ6lqaBzHN7tY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XS6bJ7tzceMnmfptS5N6AEkpGciWhxhTBnP1Bq5jVzpFshxgIIsZYt57R+CsCVDsO74l43YBCAnafs/PeXaqoR6yV7TMjarVtrQTK8py1PF2S92zWu7Lw2Uj3eAGshBywp7yCQjNgjuH4At262TrhRAZiDX6yM29KjSBfOKNe/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=otzaCpwq; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tY3K60eD; arc=none smtp.client-ip=103.168.172.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="otzaCpwq"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tY3K60eD" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 5BF5214000EE; Wed, 22 Oct 2025 10:13:20 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Wed, 22 Oct 2025 10:13:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1761142400; x= 1761228800; bh=X3IeJrkHtGzd9X5Z24nI2OKwMJN41WkONpqIIM/S7cY=; b=o tzaCpwq9kYjtkrDX08cos9nHgNrXYQ3pIu8qLfZ2Ij80kgb+zBUwTgQQq8yZ/x5/ v7M5f53/FjOr5/7MDFxAEGGBX+eqBlAfl9flwfrcKpuUaAaZBitMFzft14t6X/vq 2P7ndjKUoM4kjQwZbnxRGjPsfteARbWq/nfydpJyqlUwVYAqNpQ8dgyx2CGihhQG E8hhF7luqgY6RqUCYvZAq0Sogswik++dgpVATKKu36WFz974lxY+PwfwcOowxnF1 clSW+yM6cC8VsviNV9BBDUlrE5amb+FZXudVAvBZYWvOcooSXTsE7nNFrwpa0sBs wvaMhDB2Gi/X+POd3T1CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1761142400; x=1761228800; bh=X3IeJrkHtGzd9X5Z24nI2OKwMJN41WkONpq IIM/S7cY=; b=tY3K60eD0qnU1sfu1QLXcJMeXXoaqFNRwte69et2EbLnrkHoKU9 Sev9tW36GpQYNgy+OG4p0F4apLMjVGk89Hp2nfA/4kDqp1bnkJZ+3wnqNAUsEa1E wLvqFiX4B5i3LJEvOgzZbsrtzE2Lot58VRvvl1dVUuSM1Bdw3S2ARTa8O8Imjl3j ovrrZupuS9JPz+P6S43m9Dc+4TyMRafsfZHb/qafYtNWvXpr2dediyhdS9f+7AqN SJy8Q4pU+SWvmHsdl5fkEsMjWMeu6PvznT+IjnOwgseQuYO1IhawPJvivSUvsZot MeQxNjuq4Lm5xOX2vVBlJrb2AKu6f6/o8fg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddugeefjeekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtrodttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepjeekleevleekfefgueehveejueekvdehvdeugedvkeelgefhleegieev ffdtuedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedutddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheprhgrlhhfsehmrghnuggvlhgsihhtrdgtoh hmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghp thhtohepshhtvghffhgvnhdrkhhlrghsshgvrhhtsehsvggtuhhnvghtrdgtohhmpdhrtg hpthhtohephhgvrhgsvghrthesghhonhguohhrrdgrphgrnhgrrdhorhhgrdgruhdprhgt phhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepvgguuh hmrgiivghtsehgohhoghhlvgdrtghomhdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghl rdhorhhgpdhrtghpthhtohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtth hopehhohhrmhhssehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Oct 2025 10:13:18 -0400 (EDT) Date: Wed, 22 Oct 2025 16:13:16 +0200 From: Sabrina Dubroca To: Ralf Lici Cc: netdev@vger.kernel.org, Steffen Klassert , Herbert Xu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Antonio Quartulli Subject: Re: [PATCH net v3 2/3] espintcp: use datagram_poll_queue for socket readiness Message-ID: References: <20251021100942.195010-1-ralf@mandelbit.com> <20251021100942.195010-3-ralf@mandelbit.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251021100942.195010-3-ralf@mandelbit.com> 2025-10-21, 12:09:41 +0200, Ralf Lici wrote: > espintcp uses a custom queue (ike_queue) to deliver packets to > userspace. The polling logic relies on datagram_poll, which checks > sk_receive_queue, which can lead to false readiness signals when that > queue contains non-userspace packets. > > Switch espintcp_poll to use datagram_poll_queue with ike_queue, ensuring > poll only signals readiness when userspace data is actually available. > > Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)") > Signed-off-by: Ralf Lici > --- > net/xfrm/espintcp.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Sabrina Dubroca -- Sabrina