From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 600662D7BF for ; Wed, 22 Oct 2025 14:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142690; cv=none; b=QSX3PHKmHtlNjXk1NogXwZC6YiGBiDqI/A0nKVMHYK8jFM1sLLX4czA1E7/aHndnx12ZoW7TB6rntmG1N4jhlztHNtpiUj5M3WxWVD/z4tyXB00cD0j6lI8gXbtobsPn+sK5lkKved74WcaviCiY9N3wk02djCyhzRslZyqmRRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761142690; c=relaxed/simple; bh=q3IpH5y6nurJNk8qRCre5QviDTtosg0fQPKWNipFaqI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xi927XADrMGuUGR3vTy5ahAPe5qGeYvH1aEOUvwHsgZFvZXN3sac/jAX8hmuOEkReeRiGs4xKqt/sq+3QL6HX3WFeXdDkaMIx6VZEc8qebIzQpVCQ4omihNIhTnSIC2YWUasgVXxs7jEYCFifP0oXNAXWewN3eNNJJ4B8lXqEmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=dtTUwbII; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=RgbyuhpC; arc=none smtp.client-ip=103.168.172.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="dtTUwbII"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RgbyuhpC" Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 7BA671400068; Wed, 22 Oct 2025 10:18:05 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Wed, 22 Oct 2025 10:18:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1761142685; x= 1761229085; bh=CGM9Ng0cDJJ6KHiY0zOyqatlhZf7mJg0BA1esw5pkNI=; b=d tTUwbIIUQZERqXMbJyc8Htx1JPKJp8O3TXGMi/x9lqhKYt4XTgWpfn5lbhq6HRME CYSLFipjXD9dORThZdg0db4M3ZxvSQpC92b5KvzqfbE1w5Y6jHDqkd15YtxoNacb 7aaLpxFUbuyHtgWkADYDdidXrUJnGVD0GO0r3oE93ltbDB87JxsNQfYIJIuids/v uaMRwf+ZgqUvVJ7nCSl1O1H7/avdixfByZQX4K/+mZ6cv0AfxOiSfeV8oL1fGHoP widPd5eNIxPyfrrGKzbDrXvAI54LAsE2rT3Bs7ILbjqJAJX95eT4DDy2vHTpTcVN TW5pJOOLVnSoRD5jF4tmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1761142685; x=1761229085; bh=CGM9Ng0cDJJ6KHiY0zOyqatlhZf7mJg0BA1 esw5pkNI=; b=RgbyuhpC158182rjUp3LDCYjQeh6d86G8wgJKuggLkxWeADIQ5i JcKpSLynZW6RIRDxx4hPVk66TifKd/MQQkKGItpjFGZH6Lu4q2PfDF0v3n6W6BLO 09iv9zQe7ZIcHbne67fP8ErKhAO/eR3Nz+6oGpTTb4iTy2X8VTHgV0DJbNNS4arh k5BVTGSx+QdZ9U+iwFLqRI5+LWfb2CufH7705ALwqaCtBv1z698NSBL5xgfXZt7E qRGnbdX+1ufbM8xV8rxBf2mbVPNTyKEO0UaU0z9eJId09VXHVsrgm6ddQe9w+Lnl rIRnYmPOSNbA9/bTmsb7LuAt9LoLkucQ6ow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddugeefkedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeekpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehrrghlfhesmhgrnhguvghlsghithdrtghomh dprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphht thhopegrnhhtohhnihhosehophgvnhhvphhnrdhnvghtpdhrtghpthhtoheprghnughrvg ifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvghm lhhofhhtrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomh dprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepphgrsggv nhhisehrvgguhhgrthdrtghomh X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Oct 2025 10:18:04 -0400 (EDT) Date: Wed, 22 Oct 2025 16:18:03 +0200 From: Sabrina Dubroca To: Ralf Lici Cc: netdev@vger.kernel.org, Antonio Quartulli , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net v3 3/3] ovpn: use datagram_poll_queue for socket readiness in TCP Message-ID: References: <20251021100942.195010-1-ralf@mandelbit.com> <20251021100942.195010-4-ralf@mandelbit.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251021100942.195010-4-ralf@mandelbit.com> 2025-10-21, 12:09:42 +0200, Ralf Lici wrote: > openvpn TCP encapsulation uses a custom queue to deliver packets to > userspace. Currently it relies on datagram_poll, which checks > sk_receive_queue, leading to false readiness signals when that queue > contains non-userspace packets. > > Switch ovpn_tcp_poll to use datagram_poll_queue with the peer's > user_queue, ensuring poll only signals readiness when userspace data is > actually available. Also refactor ovpn_tcp_poll in order to enforce the > assumption we can make on the lifetime of ovpn_sock and peer. > > Fixes: 11851cbd60ea ("ovpn: implement TCP transport") > Signed-off-by: Antonio Quartulli > Signed-off-by: Ralf Lici > --- > drivers/net/ovpn/tcp.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) Reviewed-by: Sabrina Dubroca Thanks Ralf. -- Sabrina