* [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message
@ 2025-10-21 19:32 Alok Tiwari
2025-10-22 14:48 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Alok Tiwari @ 2025-10-21 19:32 UTC (permalink / raw)
To: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, kuba, davem,
edumazet, pabeni, horms, intel-wired-lan, netdev
Cc: alok.a.tiwarilinux, alok.a.tiwari
Corrected the dev_warn format string:
- "Vlan id %d\n is not added" -> "Vlan id %d is not added\n"
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index 61dfcd8cb370..ac57212ab02b 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -1235,7 +1235,7 @@ static int igbvf_vlan_rx_add_vid(struct net_device *netdev,
spin_lock_bh(&hw->mbx_lock);
if (hw->mac.ops.set_vfta(hw, vid, true)) {
- dev_warn(&adapter->pdev->dev, "Vlan id %d\n is not added", vid);
+ dev_warn(&adapter->pdev->dev, "Vlan id %d is not added\n", vid);
spin_unlock_bh(&hw->mbx_lock);
return -EINVAL;
}
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message
2025-10-21 19:32 [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message Alok Tiwari
@ 2025-10-22 14:48 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2025-10-22 14:48 UTC (permalink / raw)
To: Alok Tiwari
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, kuba, davem,
edumazet, pabeni, intel-wired-lan, netdev, alok.a.tiwarilinux
On Tue, Oct 21, 2025 at 12:32:01PM -0700, Alok Tiwari wrote:
> Corrected the dev_warn format string:
> - "Vlan id %d\n is not added" -> "Vlan id %d is not added\n"
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Interesting, there seem to be some other cases of this, at least under
net/divers. Do you plan to address those too?
In any case, looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-22 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 19:32 [PATCH net-next] igbvf: fix misplaced newline in VLAN add warning message Alok Tiwari
2025-10-22 14:48 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).